* [PATCH] atl1c: remove redundant assignment to variable size
@ 2022-03-18 0:50 Colin Ian King
2022-03-18 21:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-03-18 0:50 UTC (permalink / raw)
To: Chris Snook, David S . Miller, Jakub Kicinski, Paolo Abeni,
Gatis Peisenieks, netdev
Cc: kernel-janitors, linux-kernel, llvm
Variable sie is being assigned a value that is never read. The
The assignment is redundant and can be removed.
Cleans up clang scan build warning:
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1054:22: warning:
Although the value stored to 'size' is used in the enclosing
expression, the value is never actually read from 'size'
[deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index f50604f3e541..49459397993e 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -1051,7 +1051,7 @@ static int atl1c_setup_ring_resources(struct atl1c_adapter *adapter)
* each ring/block may need up to 8 bytes for alignment, hence the
* additional bytes tacked onto the end.
*/
- ring_header->size = size =
+ ring_header->size =
sizeof(struct atl1c_tpd_desc) * tpd_ring->count * tqc +
sizeof(struct atl1c_rx_free_desc) * rfd_ring->count * rqc +
sizeof(struct atl1c_recv_ret_status) * rfd_ring->count * rqc +
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atl1c: remove redundant assignment to variable size
2022-03-18 0:50 [PATCH] atl1c: remove redundant assignment to variable size Colin Ian King
@ 2022-03-18 21:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-18 21:30 UTC (permalink / raw)
To: Colin Ian King
Cc: chris.snook, davem, kuba, pabeni, gatis, netdev, kernel-janitors,
linux-kernel, llvm
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 18 Mar 2022 00:50:21 +0000 you wrote:
> Variable sie is being assigned a value that is never read. The
> The assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1054:22: warning:
> Although the value stored to 'size' is used in the enclosing
> expression, the value is never actually read from 'size'
> [deadcode.DeadStores]
>
> [...]
Here is the summary with links:
- atl1c: remove redundant assignment to variable size
https://git.kernel.org/netdev/net-next/c/0978e5919c28
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-18 0:50 [PATCH] atl1c: remove redundant assignment to variable size Colin Ian King
2022-03-18 21:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).