From: "Marek Behún" <kabel@kernel.org>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, kuba@kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Require ops be implemented to claim STU support
Date: Sat, 19 Mar 2022 20:00:13 +0100 [thread overview]
Message-ID: <20220319200013.7fcdf637@thinkpad> (raw)
In-Reply-To: <20220318201321.4010543-2-tobias@waldekranz.com>
On Fri, 18 Mar 2022 21:13:20 +0100
Tobias Waldekranz <tobias@waldekranz.com> wrote:
> Simply having a physical STU table in the device doesn't do us any
> good if there's no implementation of the relevant ops to access that
> table. So ensure that chips that claim STU support can also talk to
> the hardware.
>
> This fixes an issue where chips that had a their ->info->max_sid
> set (due to their family membership), but no implementation (due to
> their chip-specific ops struct) would fail to probe.
>
> Fixes: 49c98c1dc7d9 ("net: dsa: mv88e6xxx: Disentangle STU from VTU")
> Reported-by: Marek Behún <kabel@kernel.org>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
Tested-by: Marek Behún <kabel@kernel.org>
next prev parent reply other threads:[~2022-03-19 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 20:13 [PATCH net-next 0/2] net: dsa: mv88e6xxx: MST Fixes Tobias Waldekranz
2022-03-18 20:13 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: Require ops be implemented to claim STU support Tobias Waldekranz
2022-03-18 20:40 ` Vladimir Oltean
2022-03-18 21:23 ` Florian Fainelli
2022-03-19 19:00 ` Marek Behún [this message]
2022-03-18 20:13 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: Ensure STU support in VLAN MSTI callback Tobias Waldekranz
2022-03-18 20:41 ` Vladimir Oltean
2022-03-18 21:23 ` Florian Fainelli
2022-03-19 19:00 ` Marek Behún
2022-03-21 23:00 ` [PATCH net-next 0/2] net: dsa: mv88e6xxx: MST Fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220319200013.7fcdf637@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).