[PATCH bpf] selftests/bpf: exit with error code if test failed

[PATCH bpf] selftests/bpf: exit with error code if test failed

[Hangbin Liu]

The test_lirc_mode2.sh test exit with 0 even test failed. Fix it by
exiting with an error code.

Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/bpf/test_lirc_mode2.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh
index ec4e15948e40..420dc86362f5 100755
--- a/tools/testing/selftests/bpf/test_lirc_mode2.sh
+++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh
@@ -36,3 +36,5 @@ then
 		echo -e ${GREEN}"PASS: $TYPE"${NC}
 	fi
 fi
+
+exit $ret
-- 
2.35.1

Re: [PATCH bpf] selftests/bpf: exit with error code if test failed

[Daniel Borkmann]

On 3/17/22 8:18 AM, Hangbin Liu wrote:
> The test_lirc_mode2.sh test exit with 0 even test failed. Fix it by
> exiting with an error code.
> 
> Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>   tools/testing/selftests/bpf/test_lirc_mode2.sh | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh
> index ec4e15948e40..420dc86362f5 100755
> --- a/tools/testing/selftests/bpf/test_lirc_mode2.sh
> +++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh
> @@ -36,3 +36,5 @@ then
>   		echo -e ${GREEN}"PASS: $TYPE"${NC}
>   	fi
>   fi
> +
> +exit $ret

nit: Shouldn't this also exit with error if no test_lirc_mode2_user was run?

[PATCHv2 bpf] selftests/bpf/test_lirc_mode2.sh: exit with proper code

[Hangbin Liu]

When test_lirc_mode2_user exec failed, the test report failed but still
exit with 0. Fix it by exiting with an error code.

Another issue is for the LIRCDEV checking. With bash -n, we need to quote
the variable, or it will always be true. So if test_lirc_mode2_user was
not run, just exit with skip code.

Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/bpf/test_lirc_mode2.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh
index ec4e15948e40..5252b91f48a1 100755
--- a/tools/testing/selftests/bpf/test_lirc_mode2.sh
+++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh
@@ -3,6 +3,7 @@
 
 # Kselftest framework requirement - SKIP code is 4.
 ksft_skip=4
+ret=$ksft_skip
 
 msg="skip all tests:"
 if [ $UID != 0 ]; then
@@ -25,7 +26,7 @@ do
 	fi
 done
 
-if [ -n $LIRCDEV ];
+if [ -n "$LIRCDEV" ];
 then
 	TYPE=lirc_mode2
 	./test_lirc_mode2_user $LIRCDEV $INPUTDEV
@@ -36,3 +37,5 @@ then
 		echo -e ${GREEN}"PASS: $TYPE"${NC}
 	fi
 fi
+
+exit $ret
-- 
2.35.1

Re: [PATCHv2 bpf] selftests/bpf/test_lirc_mode2.sh: exit with proper code

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Mon, 21 Mar 2022 10:41:49 +0800 you wrote:
> When test_lirc_mode2_user exec failed, the test report failed but still
> exit with 0. Fix it by exiting with an error code.
> 
> Another issue is for the LIRCDEV checking. With bash -n, we need to quote
> the variable, or it will always be true. So if test_lirc_mode2_user was
> not run, just exit with skip code.
> 
> [...]

Here is the summary with links:
  - [PATCHv2,bpf] selftests/bpf/test_lirc_mode2.sh: exit with proper code
    https://git.kernel.org/bpf/bpf-next/c/ec80906b0fbd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html