Re: linux-next: build failure after merge of the net-next tree

Jeff Kirsher
2015-02-11T04:51:33Z

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On Tue, 2015-02-10 at 22:02 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (i386
> allmodconfig and a few others) failed like this:
>
> drivers/net/ethernet/intel/i40e/i40e_txrx.c: In function
> 'i40e_setup_rx_descriptors':
> drivers/net/ethernet/intel/i40e/i40e_txrx.c:1101:3: error:
> incompatible type for argument 1 of '__seqcount_init'
> include/linux/seqlock.h:53:20: note: expected 'struct seqcount_t *'
> but argument is of type 'seqcount_t'
>
> Caused by commit 638702bd59a3 ("i40e/i40evf: Add call to
> u64_stats_init
> to init").
>
> Discovered after the release, so no fix done.
>
> The indentation of the lines added by that patch is also a bit
> strange.

Yeah, this was fixed with the follow on patch:

commit c07a213db1437a8fd40c328e6a2c426723caec65
Author: Carolyn Wyborny <carolyn.wyborny@intel.com>
Date: Tue Feb 10 07:33:15 2015 +0000

i40e: Fix for stats init function call in Rx setup

This patch fixes indentation issue and error found in argument
reported by static analysis. Without this patch, sparse and other
static analysis errors will be found.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]