Re: linux-next: build failure after merge of the net-next tree

Saeed Mahameed
2022-03-22T06:18:40Z

On 21 Mar 14:45, Jakub Kicinski wrote:
>On Mon, 21 Mar 2022 18:39:41 +1100 Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the net-next tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> In file included from include/linux/string.h:253,
>> from include/linux/bitmap.h:11,
>> from include/linux/cpumask.h:12,
>> from arch/x86/include/asm/cpumask.h:5,
>> from arch/x86/include/asm/msr.h:11,
>> from arch/x86/include/asm/processor.h:22,
>> from arch/x86/include/asm/timex.h:5,
>> from include/linux/timex.h:65,
>> from include/linux/time32.h:13,
>> from include/linux/time.h:60,
>> from include/linux/ktime.h:24,
>> from include/linux/timer.h:6,
>> from include/linux/netdevice.h:24,
>> from include/trace/events/xdp.h:8,
>> from include/linux/bpf_trace.h:5,
>> from drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:33:
>> In function 'fortify_memset_chk',
>> inlined from 'mlx5e_xmit_xdp_frame' at drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:438:3:
>> include/linux/fortify-string.h:242:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
>> 242 | __write_overflow_field(p_size_field, size);
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>> 9ded70fa1d81 ("net/mlx5e: Don't prefill WQEs in XDP SQ in the multi buffer mode")
>>
>> exposed by the kspp tree.
>>
>> I have applied the following fix patch for today (a better one is
>> probably possible).
>
>Hi Saeed,
>
>thoughts?
>

I forgot about this warning in net :-/ we did a similar patch to net to
avoid it, Stephen's patch is correct,
I will submit his fixup to net-next in the morning.