From: Olivier Matz <olivier.matz@6wind.com>
To: netdev@vger.kernel.org
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
stable@vger.kernel.org,
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: [PATCH net 1/2] ixgbe: fix bcast packets Rx on VF after promisc removal
Date: Fri, 25 Mar 2022 15:02:49 +0100 [thread overview]
Message-ID: <20220325140250.21663-2-olivier.matz@6wind.com> (raw)
In-Reply-To: <20220325140250.21663-1-olivier.matz@6wind.com>
After a VF requested to remove the promiscuous flag on an interface, the
broadcast packets are not received anymore. This breaks some protocols
like ARP.
In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM
bit (Broadcast Accept) on promiscuous removal.
This flag is already set by default in ixgbe_set_vmolr() on VF reset.
Fixes: 8443c1a4b192 ("ixgbe, ixgbevf: Add new mbox API xcast mode")
Cc: stable@vger.kernel.org
Cc: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 7f11c0a8e7a9..8d108a78941b 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -1184,9 +1184,9 @@ static int ixgbe_update_vf_xcast_mode(struct ixgbe_adapter *adapter,
switch (xcast_mode) {
case IXGBEVF_XCAST_MODE_NONE:
- disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |
+ disable = IXGBE_VMOLR_ROMPE |
IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;
- enable = 0;
+ enable = IXGBE_VMOLR_BAM;
break;
case IXGBEVF_XCAST_MODE_MULTI:
disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;
--
2.30.2
next prev parent reply other threads:[~2022-03-25 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 14:02 [PATCH net 0/2] ixgbe: fix promiscuous mode on VF Olivier Matz
2022-03-25 14:02 ` Olivier Matz [this message]
2022-03-25 14:02 ` [PATCH net 2/2] ixgbe: fix unexpected VLAN Rx in promisc " Olivier Matz
2022-04-06 8:18 ` [PATCH net 0/2] ixgbe: fix promiscuous " Olivier Matz
2022-04-06 9:00 ` [Intel-wired-lan] " Paul Menzel
-- strict thread matches above, loose matches on Subject: below --
2022-06-07 18:15 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-06-07 Tony Nguyen
2022-06-07 18:15 ` [PATCH net 1/2] ixgbe: fix bcast packets Rx on VF after promisc removal Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325140250.21663-2-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox