From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A52CC433EF for ; Tue, 29 Mar 2022 22:56:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237604AbiC2W6A (ORCPT ); Tue, 29 Mar 2022 18:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238783AbiC2W55 (ORCPT ); Tue, 29 Mar 2022 18:57:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94E8C1FF218; Tue, 29 Mar 2022 15:56:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2D620B81AC0; Tue, 29 Mar 2022 22:56:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4853BC340ED; Tue, 29 Mar 2022 22:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648594570; bh=ksuq1R8pSpjJONhoUKRGAf+f3bC+JKVtq1dWnWz3wNU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IEEH07hp4AwMgoIeNeOBPvNW99HUs9/erJvbuIyH0Ken+cf7aXHjsNJyR/OtWd+++ b3/ySZiyOwGfBRKFOMhL5CHvzf7LvKjEM0TK/gEcIoFjQud5xxHFYX1ioBnnBxyLzd wLmn/5MOszcCuBmiZH/1lJxSk2EZvaHhB+qe0ctvk1WkmPKSfFEKALd84XvbzwTUUh MhyKVApRE87yj53FaptWGgbmwuCPcM7AVzOdPuNDiR42Cy1o9loL3/wnhI43zZTjcs oXW7iHXWfLqPdS1ixDyIV+3IoD/bmzGa4dxe9eKQebH31MOnccUbKpHKQlX2wTve8p dh6GFb5/MuFCw== Date: Tue, 29 Mar 2022 15:56:09 -0700 From: Jakub Kicinski To: andrew@lunn.ch Cc: Andy Chiu , radhey.shyam.pandey@xilinx.com, robert.hancock@calian.com, michal.simek@xilinx.com, davem@davemloft.net, pabeni@redhat.com, robh+dt@kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, Greentime Hu Subject: Re: [PATCH v7 net 4/4] net: axiemac: use a phandle to reference pcs_phy Message-ID: <20220329155609.674caa9c@kernel.org> In-Reply-To: <20220329024921.2739338-5-andy.chiu@sifive.com> References: <20220329024921.2739338-1-andy.chiu@sifive.com> <20220329024921.2739338-5-andy.chiu@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 29 Mar 2022 10:49:21 +0800 Andy Chiu wrote: > In some SGMII use cases where both a fixed link external PHY and the > internal PCS/PMA PHY need to be configured, we should explicitly use a > phandle "pcs-phy" to get the reference to the PCS/PMA PHY. Otherwise, the > driver would use "phy-handle" in the DT as the reference to both the > external and the internal PCS/PMA PHY. > > In other cases where the core is connected to a SFP cage, we could still > point phy-handle to the intenal PCS/PMA PHY, and let the driver connect > to the SFP module, if exist, via phylink. > > Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode) > Signed-off-by: Andy Chiu > Reviewed-by: Greentime Hu > Reviewed-by: Robert Hancock I'm not sure if this is a fix or adding support for a new configuration. Andrew, WDYT? If it really is a fix and needs to be backported we should take patch 2 out of this series, and post it separately later. Refactoring does not belong in stable trees.