* [PATCH] net: sparx5: uses, depends on BRIDGE or !BRIDGE
@ 2022-03-30 1:20 Randy Dunlap
2022-03-30 1:51 ` Jakub Kicinski
2022-03-31 2:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-03-30 1:20 UTC (permalink / raw)
To: netdev
Cc: patches, Randy Dunlap, kernel test robot, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, UNGLinuxDriver, David S. Miller,
Jakub Kicinski, Paolo Abeni
Fix build errors when BRIDGE=m and SPARX5_SWITCH=y:
riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L305':
sparx5_switchdev.c:(.text+0xdb0): undefined reference to `br_vlan_enabled'
riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L283':
sparx5_switchdev.c:(.text+0xee0): undefined reference to `br_vlan_enabled'
Fixes: 3cfa11bac9bb ("net: sparx5: add the basic sparx5 driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: Lars Povlsen <lars.povlsen@microchip.com>
Cc: Steen Hegelund <Steen.Hegelund@microchip.com>
Cc: UNGLinuxDriver@microchip.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
drivers/net/ethernet/microchip/sparx5/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20220329.orig/drivers/net/ethernet/microchip/sparx5/Kconfig
+++ linux-next-20220329/drivers/net/ethernet/microchip/sparx5/Kconfig
@@ -5,6 +5,7 @@ config SPARX5_SWITCH
depends on OF
depends on ARCH_SPARX5 || COMPILE_TEST
depends on PTP_1588_CLOCK_OPTIONAL
+ depends on BRIDGE || BRIDGE=n
select PHYLINK
select PHY_SPARX5_SERDES
select RESET_CONTROLLER
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: sparx5: uses, depends on BRIDGE or !BRIDGE
2022-03-30 1:20 [PATCH] net: sparx5: uses, depends on BRIDGE or !BRIDGE Randy Dunlap
@ 2022-03-30 1:51 ` Jakub Kicinski
2022-03-31 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-03-30 1:51 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, patches, kernel test robot, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, David S. Miller, Paolo Abeni,
bjarni.jonasson, p.zabel
On Tue, 29 Mar 2022 18:20:25 -0700 Randy Dunlap wrote:
> Fix build errors when BRIDGE=m and SPARX5_SWITCH=y:
>
> riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L305':
> sparx5_switchdev.c:(.text+0xdb0): undefined reference to `br_vlan_enabled'
> riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L283':
> sparx5_switchdev.c:(.text+0xee0): undefined reference to `br_vlan_enabled'
>
> Fixes: 3cfa11bac9bb ("net: sparx5: add the basic sparx5 driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Cc: Lars Povlsen <lars.povlsen@microchip.com>
> Cc: Steen Hegelund <Steen.Hegelund@microchip.com>
> Cc: UNGLinuxDriver@microchip.com
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
Gotta CC all the authors of the change under Fixes, please.
Adding them now.
> --- linux-next-20220329.orig/drivers/net/ethernet/microchip/sparx5/Kconfig
> +++ linux-next-20220329/drivers/net/ethernet/microchip/sparx5/Kconfig
> @@ -5,6 +5,7 @@ config SPARX5_SWITCH
> depends on OF
> depends on ARCH_SPARX5 || COMPILE_TEST
> depends on PTP_1588_CLOCK_OPTIONAL
> + depends on BRIDGE || BRIDGE=n
> select PHYLINK
> select PHY_SPARX5_SERDES
> select RESET_CONTROLLER
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: sparx5: uses, depends on BRIDGE or !BRIDGE
2022-03-30 1:20 [PATCH] net: sparx5: uses, depends on BRIDGE or !BRIDGE Randy Dunlap
2022-03-30 1:51 ` Jakub Kicinski
@ 2022-03-31 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-31 2:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, patches, lkp, horatiu.vultur, lars.povlsen,
Steen.Hegelund, UNGLinuxDriver, davem, kuba, pabeni
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 29 Mar 2022 18:20:25 -0700 you wrote:
> Fix build errors when BRIDGE=m and SPARX5_SWITCH=y:
>
> riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L305':
> sparx5_switchdev.c:(.text+0xdb0): undefined reference to `br_vlan_enabled'
> riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L283':
> sparx5_switchdev.c:(.text+0xee0): undefined reference to `br_vlan_enabled'
>
> [...]
Here is the summary with links:
- net: sparx5: uses, depends on BRIDGE or !BRIDGE
https://git.kernel.org/netdev/net/c/f9512d654f62
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-31 2:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-30 1:20 [PATCH] net: sparx5: uses, depends on BRIDGE or !BRIDGE Randy Dunlap
2022-03-30 1:51 ` Jakub Kicinski
2022-03-31 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).