From: Artem Savkov <asavkov@redhat.com>
To: netdev@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
asavkov@redhat.com, Josh Poimboeuf <jpoimboe@redhat.com>
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
dsahern@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/2] net: make tcp keepalive timer upper bound
Date: Wed, 30 Mar 2022 10:20:46 +0200 [thread overview]
Message-ID: <20220330082046.3512424-3-asavkov@redhat.com> (raw)
In-Reply-To: <20220330082046.3512424-1-asavkov@redhat.com>
Make sure TCP keepalive timer does not expire late. Switching to upper
bound timers means it can fire off early but in case of keepalive
tcp_keepalive_timer() handler checks elapsed time and resets the timer
if it was triggered early. This results in timer "cascading" to a
higher precision and being just a couple of milliseconds off it's
original mark.
Signed-off-by: Artem Savkov <asavkov@redhat.com>
---
net/ipv4/inet_connection_sock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index 1e5b53c2bb267..bb2dbfb6f5b50 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -589,7 +589,7 @@ EXPORT_SYMBOL(inet_csk_delete_keepalive_timer);
void inet_csk_reset_keepalive_timer(struct sock *sk, unsigned long len)
{
- sk_reset_timer(sk, &sk->sk_timer, jiffies + len);
+ sk_reset_timer(sk, &sk->sk_timer, jiffies + upper_bound_timeout(len));
}
EXPORT_SYMBOL(inet_csk_reset_keepalive_timer);
--
2.34.1
next prev parent reply other threads:[~2022-03-30 8:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 11:16 [PATCH 0/2] Upper bound mode for kernel timers Artem Savkov
2022-03-23 11:16 ` [PATCH 1/2] timer: introduce upper bound timers Artem Savkov
2022-03-23 18:40 ` Josh Poimboeuf
2022-03-24 9:14 ` [PATCH v2 0/2] Upper bound mode for kernel timers Artem Savkov
2022-03-24 9:14 ` [PATCH v2 1/2] timer: introduce upper bound timers Artem Savkov
2022-03-24 9:15 ` [PATCH v2 2/2] net: make tcp keepalive timer upper bound Artem Savkov
2022-03-24 12:28 ` [PATCH 1/2] timer: introduce upper bound timers Thomas Gleixner
2022-03-24 13:54 ` Thomas Gleixner
2022-03-26 21:13 ` Thomas Gleixner
2022-03-30 8:20 ` [PATCH v3 0/2] Upper bound kernel timers Artem Savkov
2022-03-30 8:20 ` [PATCH v3 1/2] timer: add a function to adjust timeouts to be upper bound Artem Savkov
2022-03-30 13:40 ` Anna-Maria Behnsen
2022-04-02 6:55 ` Artem Savkov
2022-04-05 15:33 ` Thomas Gleixner
2022-04-07 7:52 ` [PATCH v4 0/2] Upper bound kernel timers Artem Savkov
2022-04-07 7:52 ` [PATCH v4 1/2] timer: add a function to adjust timeouts to be upper bound Artem Savkov
2022-04-08 0:37 ` Thomas Gleixner
2022-04-08 5:39 ` Josh Poimboeuf
2022-04-12 13:42 ` Artem Savkov
2022-05-05 13:18 ` [PATCH v5 0/2] Upper bound kernel timers Artem Savkov
2022-05-05 13:18 ` [PATCH v5 1/2] timer: add a function to adjust timeouts to be upper bound Artem Savkov
2022-05-05 13:18 ` [PATCH v5 2/2] net: make tcp keepalive timer " Artem Savkov
2022-05-05 17:56 ` Josh Poimboeuf
2022-05-06 6:39 ` Artem Savkov
2022-05-06 16:24 ` Josh Poimboeuf
2022-07-26 22:42 ` [PATCH v5 0/2] Upper bound kernel timers Josh Poimboeuf
2022-04-07 7:52 ` [PATCH v4 2/2] net: make tcp keepalive timer upper bound Artem Savkov
[not found] ` <Yk1i3WrcVIICAiF0@samus.usersys.redhat.com>
2022-04-07 23:26 ` [PATCH v3 1/2] timer: add a function to adjust timeouts to be " Thomas Gleixner
2022-03-30 8:20 ` Artem Savkov [this message]
2022-04-02 3:09 ` [net] 6ef3f95797: UBSAN:shift-out-of-bounds_in_kernel/time/timer.c kernel test robot
2022-04-02 7:11 ` Artem Savkov
2022-03-30 10:28 ` [PATCH v3 0/2] Upper bound kernel timers David Laight
2022-03-25 7:38 ` [timer] d41e0719d5: UBSAN:shift-out-of-bounds_in_lib/flex_proportions.c kernel test robot
2022-03-25 19:14 ` Thomas Gleixner
2022-03-23 11:16 ` [PATCH 2/2] net: make tcp keepalive timer upper bound Artem Savkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330082046.3512424-3-asavkov@redhat.com \
--to=asavkov@redhat.com \
--cc=anna-maria@linutronix.de \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).