From: Jakub Kicinski <kuba@kernel.org>
To: Tomas Melin <tomas.melin@vaisala.com>
Cc: netdev@vger.kernel.org, nicolas.ferre@microchip.com,
claudiu.beznea@microchip.com, davem@davemloft.net,
pabeni@redhat.com
Subject: Re: [PATCH] net: macb: Restart tx only if queue pointer is lagging
Date: Thu, 31 Mar 2022 11:31:35 -0700 [thread overview]
Message-ID: <20220331113135.025460c1@kernel.org> (raw)
In-Reply-To: <20220325065012.279642-1-tomas.melin@vaisala.com>
On Fri, 25 Mar 2022 08:50:12 +0200 Tomas Melin wrote:
> commit 5ea9c08a8692 ("net: macb: restart tx after tx used bit read")
Ooh, I just noticed the commit ID here is from the stable tree.
Please change it to the original commit ID, so 4298388574da
and repost once the discussion settles.
> added support for restarting transmission. Restarting tx does not work
> in case controller asserts TXUBR interrupt and TQBP is already at the end
> of the tx queue. In that situation, restarting tx will immediately cause
> assertion of another TXUBR interrupt. The driver will end up in an infinite
> interrupt loop which it cannot break out of.
>
> For cases where TQBP is at the end of the tx queue, instead
> only clear TXUBR interrupt. As more data gets pushed to the queue,
> transmission will resume.
>
> This issue was observed on a Xilinx Zynq based board. During stress test of
> the network interface, driver would get stuck on interrupt loop
> within seconds or minutes causing CPU to stall.
prev parent reply other threads:[~2022-03-31 18:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 6:50 [PATCH] net: macb: Restart tx only if queue pointer is lagging Tomas Melin
2022-03-25 8:57 ` Claudiu.Beznea
2022-03-25 9:35 ` Tomas Melin
2022-03-25 13:41 ` Claudiu.Beznea
2022-03-25 14:41 ` Tomas Melin
2022-03-25 15:19 ` Claudiu.Beznea
2022-03-28 4:16 ` Melin Tomas
2022-03-30 14:27 ` Claudiu.Beznea
2022-03-31 10:08 ` Tomas Melin
2022-03-31 18:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331113135.025460c1@kernel.org \
--to=kuba@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).