From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: dsahern@kernel.org, donaldsharp72@gmail.com,
philippe.guibert@outlook.com, kuba@kernel.org,
davem@davemloft.net, idosch@idosch.org,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: [PATCH net 0/2] net: ipv4: fix nexthop route delete warning
Date: Thu, 31 Mar 2022 18:46:13 +0300 [thread overview]
Message-ID: <20220331154615.108214-1-razor@blackwall.org> (raw)
Hi,
The first patch fixes a warning that can be triggered by deleting a
nexthop route and specifying a device (more info in its commit msg).
And the second patch adds a selftest for that case.
For the fix the alternative would be to do matching on the nexthop's
attributes but I think we shouldn't since it's old-style route deletion
and nexthops are managed through a different interface, so I chose to
don't do any matching if the fib_info is a nexthop route and the user
specified old-style attributes to match on (e.g. device in this case)
which preserves the current behaviour and avoids the warning.
Thanks,
Nik
Nikolay Aleksandrov (2):
net: ipv4: fix route with nexthop object delete warning
selftests: net: add delete nexthop route warning test
net/ipv4/fib_semantics.c | 7 ++++++-
tools/testing/selftests/net/fib_nexthops.sh | 13 +++++++++++++
2 files changed, 19 insertions(+), 1 deletion(-)
--
2.35.1
next reply other threads:[~2022-03-31 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 15:46 Nikolay Aleksandrov [this message]
2022-03-31 15:46 ` [PATCH net 1/2] net: ipv4: fix route with nexthop object delete warning Nikolay Aleksandrov
2022-03-31 17:05 ` David Ahern
2022-03-31 17:17 ` Nikolay Aleksandrov
2022-03-31 17:34 ` Nikolay Aleksandrov
2022-03-31 19:31 ` Nikolay Aleksandrov
2022-04-01 1:33 ` David Ahern
2022-03-31 15:46 ` [PATCH net 2/2] selftests: net: add delete nexthop route warning test Nikolay Aleksandrov
2022-04-01 1:35 ` David Ahern
2022-04-01 7:18 ` [PATCH net 0/2] net: ipv4: fix nexthop route delete warning Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331154615.108214-1-razor@blackwall.org \
--to=razor@blackwall.org \
--cc=davem@davemloft.net \
--cc=donaldsharp72@gmail.com \
--cc=dsahern@kernel.org \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philippe.guibert@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).