netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: dsahern@kernel.org, donaldsharp72@gmail.com,
	philippe.guibert@outlook.com, kuba@kernel.org,
	davem@davemloft.net, idosch@idosch.org,
	Nikolay Aleksandrov <razor@blackwall.org>
Subject: [PATCH net v2 0/2] net: ipv4: fix nexthop route delete warning
Date: Fri,  1 Apr 2022 10:33:41 +0300	[thread overview]
Message-ID: <20220401073343.277047-1-razor@blackwall.org> (raw)

Hi,
The first patch fixes a warning that can be triggered by deleting a
nexthop route and specifying a device (more info in its commit msg).
And the second patch adds a selftest for that case.

Chose this way to fix it because we should match when deleting without
nh spec and should fail when deleting a nexthop route with old-style nh
spec because nexthop objects are managed separately, e.g.:
$ ip r show 1.2.3.4/32
1.2.3.4 nhid 12 via 192.168.11.2 dev dummy0 

$ ip r del 1.2.3.4/32
$ ip r del 1.2.3.4/32 nhid 12
<both should work>

$ ip r del 1.2.3.4/32 dev dummy0
<should fail with ESRCH>

v2: addded more to patch 01's commit message
    adjusted the test comment in patch 02

Thanks,
 Nik

Nikolay Aleksandrov (2):
  net: ipv4: fix route with nexthop object delete warning
  selftests: net: add delete nexthop route warning test

 net/ipv4/fib_semantics.c                    |  7 ++++++-
 tools/testing/selftests/net/fib_nexthops.sh | 14 ++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

-- 
2.35.1


             reply	other threads:[~2022-04-01  7:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01  7:33 Nikolay Aleksandrov [this message]
2022-04-01  7:33 ` [PATCH net v2 1/2] net: ipv4: fix route with nexthop object delete warning Nikolay Aleksandrov
2022-04-08 14:31   ` Nicolas Dichtel
2022-04-08 15:06     ` Jack Wang
2022-04-08 15:12       ` Nicolas Dichtel
2022-04-01  7:33 ` [PATCH net v2 2/2] selftests: net: add delete nexthop route warning test Nikolay Aleksandrov
2022-04-01 15:54   ` [PATCH net] selftests: net: fix nexthop warning cleanup double ip typo Nikolay Aleksandrov
2022-04-03 12:10     ` patchwork-bot+netdevbpf
2022-04-01 13:10 ` [PATCH net v2 0/2] net: ipv4: fix nexthop route delete warning patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401073343.277047-1-razor@blackwall.org \
    --to=razor@blackwall.org \
    --cc=davem@davemloft.net \
    --cc=donaldsharp72@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=idosch@idosch.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=philippe.guibert@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).