From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68271C433EF for ; Fri, 1 Apr 2022 18:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236274AbiDASM3 (ORCPT ); Fri, 1 Apr 2022 14:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236050AbiDASM1 (ORCPT ); Fri, 1 Apr 2022 14:12:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B13BC12E75B for ; Fri, 1 Apr 2022 11:10:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5851360C35 for ; Fri, 1 Apr 2022 18:10:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5227DC340EE; Fri, 1 Apr 2022 18:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648836636; bh=YBIIsVfU1lUzYS2Ml6mEX7b3TKPdqopWvYWtMmO1htU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u+ajwDaorXjGT8j54j36R+ktFObu85ILuvcPLxMVDh5nTq3wTtKHoV+LS3+Wbec2C y6vedvwU7ncm24e2cJ1cx+L8eUS6xcAoCD5zZPIDIK0JIZtevtRiG7gYhihvW5d8c9 ZkajjYKe3mGQJrhwhVUoPLOZOA6+jprgfMKNE7ND4TEursOBN2I7zQmPd4o6FXhUpE LK4ipnrIXzzAD26ilUzg4JilzdbutbQjmPeT7h8v6jkNDUnBDDcIQdLwiNTQTJ33D+ FfEN8heI9Y1haufP0av8ZyUppX70+jJs8KYRWln8lpUTSwq+4FZU1UFvxF5NstY+GW GIJI8VedlNWpA== Date: Fri, 1 Apr 2022 11:10:35 -0700 From: Jakub Kicinski To: Mattias Forsblad Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Paolo Abeni , Tobias Waldekranz Subject: Re: [PATCH v1 net-next 1/2] net: tc: dsa: Add the matchall filter with drop action for bridged DSA ports. Message-ID: <20220401111035.3b570a28@kernel.org> In-Reply-To: <20220401100418.3762272-2-mattias.forsblad@gmail.com> References: <20220401100418.3762272-1-mattias.forsblad@gmail.com> <20220401100418.3762272-2-mattias.forsblad@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 1 Apr 2022 12:04:17 +0200 Mattias Forsblad wrote: > case NETDEV_CHANGEUPPER: > + struct netdev_notifier_changeupper_info *info = ptr; I don't think C99 has been enabled, yet? You can't declare variables like this. Please fix and repost on Monday when net-next is actually opened.