From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B962EC433F5 for ; Fri, 1 Apr 2022 18:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350584AbiDASv6 (ORCPT ); Fri, 1 Apr 2022 14:51:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233785AbiDASv6 (ORCPT ); Fri, 1 Apr 2022 14:51:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A30835261 for ; Fri, 1 Apr 2022 11:50:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 240FB6144E for ; Fri, 1 Apr 2022 18:50:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F254C340EC; Fri, 1 Apr 2022 18:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648839007; bh=qkm3lHM3EHUyZ6DyLHlg1r2sFU0k93ow4bGLaUi2Ch4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kxjYSndpGeb4qwa9swiQ2A3OZ8r1V1k1WyhlGm6yqPYeBPdvvQ9yqGuJmqunhvKfx b9qoHBja2ywMG/GriKpxwRJNsWDdPO0V+ZhEDwEeEx2VwynlwMSsIS4syQmECUWxTp Gi+uLcyyqZnLRDEEbjrJaXZij6ofoPXlxPlZLz6fQV5pDbYYmF77yIM6a6fz2ws2p3 z+P6JXLBFBwMHQ14KWSHRIuTsrax4xt9Tn4yWAvZwyowsLvkjy4hJ/TtAc580EdzZv ZEDApq1t5PeTHZXrSJM/MulwmSlvGybfWF/l7XOX1M80tJbEuKZ6amiK0kEnE5A1rA UgJOb6lk3luQA== Date: Fri, 1 Apr 2022 11:50:05 -0700 From: Jakub Kicinski To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com, oliver.sang@intel.com Subject: Re: [PATCH net] xfrm: Pass flowi_oif or l3mdev as oif to xfrm_dst_lookup Message-ID: <20220401115005.0c104b01@kernel.org> In-Reply-To: <20220401015334.40252-1-dsahern@kernel.org> References: <20220401015334.40252-1-dsahern@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 31 Mar 2022 19:53:34 -0600 David Ahern wrote: > To: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com > Cc: oliver.sang@intel.com, David Ahern > Subject: [PATCH net] xfrm: Pass flowi_oif or l3mdev as oif to xfrm_dst_lookup This needs Steffen and Herbert on CC. I'd just CC them in but patch was marked as Awaiting upstream in our PW already, so repost would be better. Regardless which tree it ends up getting applied to. > The commit referenced in the Fixes tag no longer changes the > flow oif to the l3mdev ifindex. A xfrm use case was expecting > the flowi_oif to be the VRF if relevant and the change broke > that test. Update xfrm_bundle_create to pass oif if set and any > potential flowi_l3mdev if oif is not set. > > Fixes: 40867d74c374 ("net: Add l3mdev index to flow struct and avoid oif reset for port devices") > Reported-by: kernel test robot > Signed-off-by: David Ahern