From: Florian Westphal <fw@strlen.de>
To: Jaco Kroon <jaco@uls.co.za>
Cc: Florian Westphal <fw@strlen.de>,
Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: linux 5.17.1 disregarding ACK values resulting in stalled TCP connections
Date: Fri, 1 Apr 2022 14:09:58 +0200 [thread overview]
Message-ID: <20220401120958.GA28321@breakpoint.cc> (raw)
In-Reply-To: <7d08dcfd-6ba0-f972-cee3-4fa0eff8c855@uls.co.za>
Jaco Kroon <jaco@uls.co.za> wrote:
> > Eric Dumazet <edumazet@google.com> wrote:
> >> Next step would be to attempt removing _all_ firewalls, especially not
> >> common setups like yours.
> >>
> >> conntrack had a bug preventing TFO deployment for a while, because
> >> many boxes kept buggy kernel versions for years.
> >>
> >> 356d7d88e088687b6578ca64601b0a2c9d145296 netfilter: nf_conntrack: fix
> >> tcp_in_window for Fast Open
> > Jaco could also try with
> > net.netfilter.nf_conntrack_tcp_be_liberal=1
> >
> > and, if that helps, with liberal=0 and
> > sysctl net.netfilter.nf_conntrack_log_invalid=6
> >
> > (check dmesg/syslog/nflog).
>
> Our core firewalls already had nf_conntrack_tcp_be_liberal for other
> reasons (asymmetric routing combined with conntrackd left-over if I
> recall), so maybe that's why it got through there ... don't exactly want
> to just flip that setting though, is there a way to log if it would have
> dropped anything, without actually dropping it (yet)?
This means conntrack doesn't tag packets as invalid EVEN if it would
consider sequence/ack out-of-window (e.g. due to a bug).
I have a hard time seeing how tcp liberal-mode conntrack would be to
blame here.
Only thing you could also check is if
net.netfilter.nf_conntrack_checksum=0 helps (but i doubt it).
next prev parent reply other threads:[~2022-04-01 12:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1nZMdl-0006nG-0J@plastiekpoot>
2022-03-30 2:01 ` linux 5.17.1 disregarding ACK values resulting in stalled TCP connections Neal Cardwell
2022-03-30 2:40 ` Eric Dumazet
2022-03-30 2:58 ` Jaco Kroon
2022-03-30 3:48 ` Eric Dumazet
2022-03-30 6:22 ` Jaco Kroon
2022-03-30 13:56 ` Neal Cardwell
2022-03-30 15:00 ` Jaco Kroon
2022-03-30 16:19 ` Eric Dumazet
2022-03-31 15:41 ` Neal Cardwell
2022-03-31 23:06 ` Jaco Kroon
2022-04-01 0:10 ` Eric Dumazet
2022-04-01 0:15 ` Florian Westphal
2022-04-01 11:54 ` Jaco Kroon
2022-04-01 12:09 ` Florian Westphal [this message]
2022-04-01 0:33 ` Jaco Kroon
2022-04-01 0:41 ` Eric Dumazet
2022-04-01 0:54 ` Eric Dumazet
2022-04-01 11:36 ` Jaco Kroon
2022-04-01 13:54 ` Eric Dumazet
2022-04-01 14:50 ` Neal Cardwell
2022-04-01 15:39 ` Neal Cardwell
2022-04-01 15:48 ` Neal Cardwell
2022-04-02 8:42 ` Jaco Kroon
2022-04-02 13:20 ` Eric Dumazet
2022-04-02 22:02 ` Jaco Kroon
2022-04-02 14:14 ` Florian Westphal
2022-04-02 15:57 ` Neal Cardwell
2022-04-02 21:51 ` Jaco Kroon
2022-04-02 16:29 ` Neal Cardwell
2022-04-02 16:32 ` Eric Dumazet
2022-04-02 18:04 ` Neal Cardwell
2022-04-06 13:58 ` Florian Westphal
2022-04-06 19:04 ` Jozsef Kadlecsik
2022-04-07 10:26 ` Florian Westphal
2022-04-07 12:48 ` Jozsef Kadlecsik
2022-04-21 21:14 ` Eric Dumazet
2022-04-25 9:29 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401120958.GA28321@breakpoint.cc \
--to=fw@strlen.de \
--cc=edumazet@google.com \
--cc=jaco@uls.co.za \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).