From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDF47C47080 for ; Fri, 1 Apr 2022 15:37:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350311AbiDAPdq (ORCPT ); Fri, 1 Apr 2022 11:33:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350528AbiDAPAI (ORCPT ); Fri, 1 Apr 2022 11:00:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D169E5C348; Fri, 1 Apr 2022 07:47:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8317BB8240E; Fri, 1 Apr 2022 14:47:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66D09C2BBE4; Fri, 1 Apr 2022 14:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648824455; bh=DNvn4b9fu3RCVHGswno86lZheUJya2hTl9UEbDl8Meg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ro/MOEx8XAlgrpNMU7mqopPhXvqUT++XyY4+fy3utk/dz88YxPHBkr6hHERe9U1+F E5UG8eaV66AQSojioSXjRTgGHYoy6LiwsdVq5S80OQXTrEIsHKeQo6QV4sUCZuuTQX 2s9eDtHzegHxJ/5Fa+0x8DrXDBFvUiCBlsr+g8IzCFtbXYbFAeCl4e+XBjHHxI2Hae XYHYXTx3mhKvtPaT0Cgx7AtBQ3F9Jq+FnXihgJliMjc7Hy6AIQpLa53/U1Osk/qOq9 cR+A4xDC+KEOdirVZMIqbAEP3jP4QwvXoxIGBuQ0N6l0+kvr+2UeM7W5J2oTER8Mt8 ZRStc1tQB2gtQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Guang , Zeal Robot , David Yang , Richard Cochran , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 02/22] ptp: replace snprintf with sysfs_emit Date: Fri, 1 Apr 2022 10:47:09 -0400 Message-Id: <20220401144729.1955554-2-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220401144729.1955554-1-sashal@kernel.org> References: <20220401144729.1955554-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Guang [ Upstream commit e2cf07654efb0fd7bbcb475c6f74be7b5755a8fd ] coccinelle report: ./drivers/ptp/ptp_sysfs.c:17:8-16: WARNING: use scnprintf or sprintf ./drivers/ptp/ptp_sysfs.c:390:8-16: WARNING: use scnprintf or sprintf Use sysfs_emit instead of scnprintf or sprintf makes more sense. Reported-by: Zeal Robot Signed-off-by: Yang Guang Signed-off-by: David Yang Acked-by: Richard Cochran Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/ptp/ptp_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c index 48401dfcd999..f97a5eefa2e2 100644 --- a/drivers/ptp/ptp_sysfs.c +++ b/drivers/ptp/ptp_sysfs.c @@ -26,7 +26,7 @@ static ssize_t clock_name_show(struct device *dev, struct device_attribute *attr, char *page) { struct ptp_clock *ptp = dev_get_drvdata(dev); - return snprintf(page, PAGE_SIZE-1, "%s\n", ptp->info->name); + return sysfs_emit(page, "%s\n", ptp->info->name); } static DEVICE_ATTR_RO(clock_name); @@ -240,7 +240,7 @@ static ssize_t ptp_pin_show(struct device *dev, struct device_attribute *attr, mutex_unlock(&ptp->pincfg_mux); - return snprintf(page, PAGE_SIZE, "%u %u\n", func, chan); + return sysfs_emit(page, "%u %u\n", func, chan); } static ssize_t ptp_pin_store(struct device *dev, struct device_attribute *attr, -- 2.34.1