netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: dsahern@kernel.org, kuba@kernel.org, davem@davemloft.net,
	Nikolay Aleksandrov <razor@blackwall.org>
Subject: [PATCH net] selftests: net: fix nexthop warning cleanup double ip typo
Date: Fri,  1 Apr 2022 18:54:27 +0300	[thread overview]
Message-ID: <20220401155427.3238004-1-razor@blackwall.org> (raw)
In-Reply-To: <20220401073343.277047-3-razor@blackwall.org>

I made a stupid typo when adding the nexthop route warning selftest and
added both $IP and ip after it (double ip) on the cleanup path. The
error doesn't show up when running the test, but obviously it doesn't
cleanup properly after it.

Fixes: 392baa339c6a ("selftests: net: add delete nexthop route warning test")
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
---
The test is accurate either way.

 tools/testing/selftests/net/fib_nexthops.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh
index d8ede0c81ac1..b3bf5319bb0e 100755
--- a/tools/testing/selftests/net/fib_nexthops.sh
+++ b/tools/testing/selftests/net/fib_nexthops.sh
@@ -1220,8 +1220,8 @@ ipv4_fcnal()
 	[ $out1 -eq $out2 ]
 	rc=$?
 	log_test $rc 0 "Delete nexthop route warning"
-	run_cmd "$IP ip route delete 172.16.101.1/32 nhid 12"
-	run_cmd "$IP ip nexthop del id 12"
+	run_cmd "$IP route delete 172.16.101.1/32 nhid 12"
+	run_cmd "$IP nexthop del id 12"
 }
 
 ipv4_grp_fcnal()
-- 
2.35.1


  reply	other threads:[~2022-04-01 16:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01  7:33 [PATCH net v2 0/2] net: ipv4: fix nexthop route delete warning Nikolay Aleksandrov
2022-04-01  7:33 ` [PATCH net v2 1/2] net: ipv4: fix route with nexthop object " Nikolay Aleksandrov
2022-04-08 14:31   ` Nicolas Dichtel
2022-04-08 15:06     ` Jack Wang
2022-04-08 15:12       ` Nicolas Dichtel
2022-04-01  7:33 ` [PATCH net v2 2/2] selftests: net: add delete nexthop route warning test Nikolay Aleksandrov
2022-04-01 15:54   ` Nikolay Aleksandrov [this message]
2022-04-03 12:10     ` [PATCH net] selftests: net: fix nexthop warning cleanup double ip typo patchwork-bot+netdevbpf
2022-04-01 13:10 ` [PATCH net v2 0/2] net: ipv4: fix nexthop route delete warning patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401155427.3238004-1-razor@blackwall.org \
    --to=razor@blackwall.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).