From: Jakub Kicinski <kuba@kernel.org>
To: Florent Fourcot <florent.fourcot@wifirst.fr>
Cc: netdev@vger.kernel.org, cong.wang@bytedance.com,
edumazet@google.com, Jiri Pirko <jiri@mellanox.com>,
Brian Baboch <brian.baboch@wifirst.fr>
Subject: Re: [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink
Date: Tue, 5 Apr 2022 17:41:49 -0700 [thread overview]
Message-ID: <20220405174149.39a50448@kernel.org> (raw)
In-Reply-To: <20220405134237.16533-1-florent.fourcot@wifirst.fr>
On Tue, 5 Apr 2022 15:42:34 +0200 Florent Fourcot wrote:
> buffer called "ifname" given in function rtnl_dev_get
> is always valid when called by setlink/newlink,
> but contains only empty string when IFLA_IFNAME is not given. So
> IFLA_ALT_IFNAME is always ignored
>
> This patch fixes rtnl_dev_get function with a remove of ifname argument,
> and move ifname copy in do_setlink when required.
>
> It extends feature of commit 76c9ac0ee878,
> "net: rtnetlink: add possibility to use alternative names as message
> handle""
>
> Changes in v2:
> * Remove ifname argument in rtnl_dev_get/do_setlink
> functions (simplify code)
>
> Changes in v3:
> * Simplify rtnl_dev_get signature
>
> CC: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
> Signed-off-by: Brian Baboch <brian.baboch@wifirst.fr>
This patch needs to be after patch 3, AFAICT. Otherwise someone running
a bisection and landing in between the two will have a buggy build.
Please provide a cover letter for the series, now that it's 4 patches.
next prev parent reply other threads:[~2022-04-06 6:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:42 [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
2022-04-05 13:42 ` [PATCH v3 net-next 2/4] rtnetlink: return ENODEV when IFLA_ALT_IFNAME is used in dellink Florent Fourcot
2022-04-05 13:42 ` [PATCH v3 net-next 3/4] rtnetlink: return ENODEV when ifname does not exist and group is given Florent Fourcot
2022-04-06 0:47 ` Jakub Kicinski
2022-04-05 13:42 ` [PATCH v3 net-next 4/4] rtnetlink: return EINVAL when request cannot succeed Florent Fourcot
2022-04-22 3:50 ` Saeed Mahameed
2022-04-22 4:16 ` Eric Dumazet
2022-04-06 0:41 ` Jakub Kicinski [this message]
2022-04-07 12:34 ` [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
2022-04-07 16:11 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2022-04-07 12:25 [PATCH v3 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
2022-04-07 12:25 ` [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405174149.39a50448@kernel.org \
--to=kuba@kernel.org \
--cc=brian.baboch@wifirst.fr \
--cc=cong.wang@bytedance.com \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).