From: Jakub Kicinski <kuba@kernel.org>
To: Mattias Forsblad <mattias.forsblad@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH v3 net-next 0/2] net: tc: dsa: Implement offload of matchall for bridged DSA ports
Date: Tue, 5 Apr 2022 18:09:49 -0700 [thread overview]
Message-ID: <20220405180949.3dd204a1@kernel.org> (raw)
In-Reply-To: <20220404104826.1902292-1-mattias.forsblad@gmail.com>
On Mon, 4 Apr 2022 12:48:24 +0200 Mattias Forsblad wrote:
> Limitations
> If there is tc rules on a bridge and all the ports leave the bridge
> and then joins the bridge again, the indirect framwork doesn't seem
> to reoffload them at join. The tc rules need to be torn down and
> re-added.
You should unregister your callback when last DSA port leaves and
re-register when first joins. That way you'll get replay.
Also the code needs to check the matchall is highest prio.
next prev parent reply other threads:[~2022-04-06 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 10:48 [PATCH v3 net-next 0/2] net: tc: dsa: Implement offload of matchall for bridged DSA ports Mattias Forsblad
2022-04-04 10:48 ` [PATCH v3 net-next 1/2] net: tc: dsa: Add the matchall filter with drop action " Mattias Forsblad
2022-04-06 23:01 ` Vladimir Oltean
2022-04-07 14:32 ` Vladimir Oltean
2022-04-04 10:48 ` [PATCH v3 net-next 2/2] net: dsa: Implement tc offloading for drop target Mattias Forsblad
2022-04-06 23:14 ` Vladimir Oltean
2022-04-06 1:09 ` Jakub Kicinski [this message]
2022-04-06 9:24 ` [PATCH v3 net-next 0/2] net: tc: dsa: Implement offload of matchall for bridged DSA ports Mattias Forsblad
2022-04-06 11:58 ` Mattias Forsblad
2022-04-06 17:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405180949.3dd204a1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=mattias.forsblad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).