From: Jakub Kicinski <kuba@kernel.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: aelior@marvell.com, manishc@marvell.com, davem@davemloft.net,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator
Date: Tue, 5 Apr 2022 18:26:41 -0700 [thread overview]
Message-ID: <20220405182641.08cd18ff@kernel.org> (raw)
In-Reply-To: <20220405002256.22772-1-xiam0nd.tong@gmail.com>
On Tue, 5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
> struct pci_dev *qed_validate_ndev(struct net_device *ndev)
> {
> - struct pci_dev *pdev = NULL;
> + struct pci_dev *pdev;
> struct net_device *upper;
Please keep the longest-to-shortest ordering of variable declaration
lines.
next prev parent reply other threads:[~2022-04-06 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 0:22 [PATCH] qed: remove an unneed NULL check on list iterator Xiaomeng Tong
2022-04-06 1:26 ` Jakub Kicinski [this message]
2022-04-07 1:22 ` Xiaomeng Tong
-- strict thread matches above, loose matches on Subject: below --
2022-03-19 4:36 Xiaomeng Tong
2022-03-22 8:52 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405182641.08cd18ff@kernel.org \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).