[PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h

[PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h

[Christophe Leroy]

powerpc's asm/prom.h brings some headers that it doesn't
need itself.

In order to clean it up, first add missing headers in
users of asm/prom.h

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
 drivers/net/sungem_phy.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
index 4daac5fda073..ff22b6b1c686 100644
--- a/drivers/net/sungem_phy.c
+++ b/drivers/net/sungem_phy.c
@@ -29,11 +29,7 @@
 #include <linux/mii.h>
 #include <linux/ethtool.h>
 #include <linux/delay.h>
-
-#ifdef CONFIG_PPC_PMAC
-#include <asm/prom.h>
-#endif
-
+#include <linux/of.h>
 #include <linux/sungem_phy.h>
 
 /* Link modes of the BCM5400 PHY */
-- 
2.35.1

Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h

[Jakub Kicinski]

On Sat,  2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
> 
> In order to clean it up, first add missing headers in
> users of asm/prom.h

Could you resend the net-next patches you had?

They got dropped from patchwork due to net-next being closed during 
the merge window.

Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h

[Christophe Leroy]

Le 05/04/2022 à 22:22, Jakub Kicinski a écrit :
> On Sat,  2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:
>> powerpc's asm/prom.h brings some headers that it doesn't
>> need itself.
>>
>> In order to clean it up, first add missing headers in
>> users of asm/prom.h
> 
> Could you resend the net-next patches you had?

Sure I can but,

> 
> They got dropped from patchwork due to net-next being closed during
> the merge window.

https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=192363&state=*&q=&archive=&delegate=

As far as I can see they are in patchwork and two of them have been 
accepted, and this one is tagged as 'deferred', so do I have to resend it ?

Thanks
Christophe

Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h

[Jakub Kicinski]

On Wed, 6 Apr 2022 05:53:46 +0000 Christophe Leroy wrote:
> Le 05/04/2022 à 22:22, Jakub Kicinski a écrit :
> > On Sat,  2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:  
> >> powerpc's asm/prom.h brings some headers that it doesn't
> >> need itself.
> >>
> >> In order to clean it up, first add missing headers in
> >> users of asm/prom.h  
> > 
> > Could you resend the net-next patches you had?  
> 
> Sure I can but,
> 
> > 
> > They got dropped from patchwork due to net-next being closed during
> > the merge window.  
> 
> https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=192363&state=*&q=&archive=&delegate=
> 
> As far as I can see they are in patchwork and two of them have been 
> accepted, and this one is tagged as 'deferred', so do I have to resend it ?

Erm, perhaps a clerical error? I don't see them in the tree.
I'd resend both.

Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h

[Christophe Leroy]

Le 05/04/2022 à 22:22, Jakub Kicinski a écrit :
> On Sat,  2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:
>> powerpc's asm/prom.h brings some headers that it doesn't
>> need itself.
>>
>> In order to clean it up, first add missing headers in
>> users of asm/prom.h
> 
> Could you resend the net-next patches you had?
> 
> They got dropped from patchwork due to net-next being closed during
> the merge window.

Ok, I sent v2, with a bit more detailed description.

Thanks
Christophe