From: Kees Cook <keescook@chromium.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org,
gustavoars@kernel.org, kurt@linutronix.de
Subject: Re: [PATCH net] flow_dissector: fix false-positive __read_overflow2_field() warning
Date: Wed, 6 Apr 2022 14:36:14 -0700 [thread overview]
Message-ID: <202204061435.69D056F@keescook> (raw)
In-Reply-To: <20220406211521.723357-1-kuba@kernel.org>
On Wed, Apr 06, 2022 at 02:15:21PM -0700, Jakub Kicinski wrote:
> Bounds checking is unhappy that we try to copy both Ethernet
> addresses but pass pointer to the first one. Luckily destination
> address is the first field so pass the pointer to the entire header,
> whatever.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Ah yes, thanks! I had prepared this patch last week, but failed to
actually send it. :|
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-04-06 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 21:15 [PATCH net] flow_dissector: fix false-positive __read_overflow2_field() warning Jakub Kicinski
2022-04-06 21:36 ` Kees Cook [this message]
2022-04-08 11:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204061435.69D056F@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox