From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE0B6C433EF for ; Wed, 6 Apr 2022 22:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbiDFWgp (ORCPT ); Wed, 6 Apr 2022 18:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbiDFWgo (ORCPT ); Wed, 6 Apr 2022 18:36:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46EEF33C for ; Wed, 6 Apr 2022 15:34:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DDA3D61CB2 for ; Wed, 6 Apr 2022 22:34:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D87BDC385A3; Wed, 6 Apr 2022 22:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649284485; bh=cZx+qVS1NxKes38rC8PFLL/4BUjKMgKE6MqNlvMuy4U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S1IUYrUlyi6E1WBrfnxJXS12r4HhEl9e33tP5wuMBBT/Sm/oWrkqfHeGg/wNOI/6T cbCvkBYa6u1U/aJbHhF0lZ9YSv/+OxaaR7y3zhIGrec1DGN1A9ZrgE9Al5P9ZmcUgk LaxiUPGJ1EkMZzplNXTqm50otqN6z6eJpWlAcjIBVKd/JQ3ZF8RT+s653UvXeNkmFS w3CsdjfTgmZWEU/xGjdCNGiuFfhMOd9tNidmaP7DVj8tU8QsccJSVPduiGOo0BUWBU 6vLvg04rExRzUArmIhaKCmiKOY0BnQZ0wZlb6b3yrxk7VAvGCfxBXCLQ8YrsJXdes6 2o+3tVNUUzbnA== Date: Wed, 6 Apr 2022 15:34:43 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, Paolo Abeni , "David S. Miller" , Andrew Lunn , Heiner Kallweit , Russell King , Florian Fainelli , Geert Uytterhoeven , Robin Murphy Subject: Re: [PATCH net] net: mdio: don't defer probe forever if PHY IRQ provider is missing Message-ID: <20220406153443.51ad52f8@kernel.org> In-Reply-To: <20220406202323.3390405-1-vladimir.oltean@nxp.com> References: <20220406202323.3390405-1-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 6 Apr 2022 23:23:23 +0300 Vladimir Oltean wrote: > diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c > index 1becb1a731f6..1c1584fca632 100644 > --- a/drivers/net/mdio/fwnode_mdio.c > +++ b/drivers/net/mdio/fwnode_mdio.c > @@ -43,6 +43,11 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio, > int rc; > > rc = fwnode_irq_get(child, 0); > + /* Don't wait forever if the IRQ provider doesn't become available, > + * just fall back to poll mode > + */ > + if (rc == -EPROBE_DEFER) > + rc = driver_deferred_probe_check_state(&phy->mdio.dev); This one's not exported, allmodconfig build fails.