From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4664EC433F5 for ; Thu, 7 Apr 2022 00:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbiDGA1w (ORCPT ); Wed, 6 Apr 2022 20:27:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231775AbiDGA1v (ORCPT ); Wed, 6 Apr 2022 20:27:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53DE04E398 for ; Wed, 6 Apr 2022 17:25:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E082661D7E for ; Thu, 7 Apr 2022 00:25:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1C2CC385A3; Thu, 7 Apr 2022 00:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649291152; bh=u+6TV5IEMFW/3pbpMHVQbKwtXLnbQ8losSM6qCSuTLA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PPUEY7FWZEWk6JDV2lp76dYnwUgWVC3lc4Pd845/UxphOn2rqTrf86ebgVZxvrifY qjHht75+35UAPrbbQGCMAvh3fZSNIG++0e70xEWQzr2n1EVjiT2Lyq9RchcWpjATer JpIEU5DG44sGeP7H2z22L+ttn010cfZtzrl5tVp+BOnZIC1/dGHophePAyMvs0ie3n suN/u062yOVy6wfWciT9QyjIJPHHRpnVXIgyp7tgRCrXQHfmBEl0u/TuN6AnLiGbAq W+LTBr96fO3TKWEKxNwKJul3lrVJE5PkJ/vZhI8fI62G9AoLyqKGOkQo5F5sHdMr3A xaERPub4gDJBw== Date: Wed, 6 Apr 2022 17:25:50 -0700 From: Jakub Kicinski To: Vladimir Oltean , Greg Kroah-Hartman Cc: "netdev@vger.kernel.org" , Paolo Abeni , "David S. Miller" , Andrew Lunn , Heiner Kallweit , Russell King , Florian Fainelli , Geert Uytterhoeven , Robin Murphy Subject: Re: [PATCH net] net: mdio: don't defer probe forever if PHY IRQ provider is missing Message-ID: <20220406172550.6408c990@kernel.org> In-Reply-To: <20220406231956.nwe6kb6vgli2chln@skbuf> References: <20220406202323.3390405-1-vladimir.oltean@nxp.com> <20220406153443.51ad52f8@kernel.org> <20220406231956.nwe6kb6vgli2chln@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 6 Apr 2022 23:19:57 +0000 Vladimir Oltean wrote: > On Wed, Apr 06, 2022 at 03:34:43PM -0700, Jakub Kicinski wrote: > > > + if (rc == -EPROBE_DEFER) > > > + rc = driver_deferred_probe_check_state(&phy->mdio.dev); > > This one's not exported, allmodconfig build fails. > > Oops, I didn't realize that all its callers except for FWNODE_MDIO are built-in. > > Do you prefer me exporting the symbol as part of the same patch or a different one? I presume single patch is fine, but driver_deferred_probe_check_state() lives in Greg's realm, so let's add Greg in case he prefers a separate patch or more.