From: Jakub Kicinski <kuba@kernel.org>
To: Ian Wienand <iwienand@redhat.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Tom Gundersen <teg@jklm.no>,
David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH v3] net/ethernet : set default assignment identifier to NET_NAME_ENUM
Date: Wed, 6 Apr 2022 22:08:39 -0700 [thread overview]
Message-ID: <20220406220839.4f16acf6@kernel.org> (raw)
In-Reply-To: <20220406093635.1601506-1-iwienand@redhat.com>
On Wed, 6 Apr 2022 19:36:36 +1000 Ian Wienand wrote:
> As noted in the original commit 685343fc3ba6 ("net: add
> name_assign_type netdev attribute")
>
> ... when the kernel has given the interface a name using global
> device enumeration based on order of discovery (ethX, wlanY, etc)
> ... are labelled NET_NAME_ENUM.
>
> That describes this case, so set the default for the devices here to
> NET_NAME_ENUM. Current popular network setup tools like systemd use
> this only to warn if you're setting static settings on interfaces that
> might change, so it is expected this only leads to better user
> information, but not changing of interfaces, etc.
>
> Signed-off-by: Ian Wienand <iwienand@redhat.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2022-04-07 5:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 0:15 [PATCH v2] net/ethernet : set default assignment identifier to NET_NAME_ENUM Ian Wienand
2022-04-05 19:41 ` Jakub Kicinski
2022-04-06 1:56 ` Ian Wienand
2022-04-06 3:47 ` Jakub Kicinski
2022-04-06 9:36 ` [PATCH v3] " Ian Wienand
2022-04-07 5:08 ` Jakub Kicinski [this message]
2022-04-08 4:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406220839.4f16acf6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=iwienand@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).