From: "Marek Behún" <kabel@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 5/9] net: dsa: mt7530: only indicate linkmodes that can be supported
Date: Wed, 6 Apr 2022 22:34:43 +0200 [thread overview]
Message-ID: <20220406223443.193b0ce1@thinkpad> (raw)
In-Reply-To: <20220406115250.047570c1@kernel.org>
On Wed, 6 Apr 2022 11:52:50 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 06 Apr 2022 11:48:57 +0100 Russell King (Oracle) wrote:
> > - if (state->interface != PHY_INTERFACE_MODE_MII) {
> > + if (state->interface != PHY_INTERFACE_MODE_MII &&
> > + state->interface != PHY_INTERFACE_MODE_2500BASEX)
> > phylink_set(mask, 1000baseT_Full);
> > phylink_set(mask, 1000baseX_Full);
> > }
>
> Missing { here. Dunno if kbuild bot told you already.
Probably not, because next patch removes this code entirely :)
next prev parent reply other threads:[~2022-04-06 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 9:49 [PATCH net-next 0/9] net: dsa: mt7530: updates for phylink changes Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 1/9] net: dsa: mt7530: 1G can also support 1000BASE-X link mode Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 2/9] net: dsa: mt7530: populate supported_interfaces and mac_capabilities Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 3/9] net: dsa: mt7530: remove interface checks Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 4/9] net: dsa: mt7530: drop use of phylink_helper_basex_speed() Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 5/9] net: dsa: mt7530: only indicate linkmodes that can be supported Russell King (Oracle)
2022-04-06 18:52 ` Jakub Kicinski
2022-04-06 20:34 ` Marek Behún [this message]
2022-04-07 14:47 ` Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 6/9] net: dsa: mt7530: switch to use phylink_get_linkmodes() Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 7/9] net: dsa: mt7530: partially convert to phylink_pcs Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 8/9] net: dsa: mt7530: move autoneg handling to PCS validation Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 9/9] net: dsa: mt7530: mark as non-legacy Russell King (Oracle)
2022-04-06 22:35 ` [PATCH net-next 0/9] net: dsa: mt7530: updates for phylink changes Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406223443.193b0ce1@thinkpad \
--to=kabel@kernel.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).