From: Jakub Kicinski <kuba@kernel.org>
To: Florent Fourcot <florent.fourcot@wifirst.fr>
Cc: netdev@vger.kernel.org, cong.wang@bytedance.com,
edumazet@google.com, Jiri Pirko <jiri@mellanox.com>,
Brian Baboch <brian.baboch@wifirst.fr>
Subject: Re: [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink
Date: Thu, 7 Apr 2022 09:11:19 -0700 [thread overview]
Message-ID: <20220407091119.6ff5b879@kernel.org> (raw)
In-Reply-To: <748f0357-2527-edda-d08a-ac0b0a7bffef@wifirst.fr>
On Thu, 7 Apr 2022 14:34:33 +0200 Florent Fourcot wrote:
> > This patch needs to be after patch 3, AFAICT. Otherwise someone running
> > a bisection and landing in between the two will have a buggy build.
>
> I double checked and this patch compiles perfectly fine when applied
> first, at least with my .config.
> Could you be more specific on what I'm missing?
rtnl_group_changelink() was passing NULL as ifname, but with just
this patch applied we'll start using tb[IFLA_IFNAME] directly.
It's better to have your patch which rejects group settings with
tb[IFLA_IFNAME] first, to avoid changing the group + IFLA_IFNAME
behavior subtly multiple times.
next prev parent reply other threads:[~2022-04-07 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:42 [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
2022-04-05 13:42 ` [PATCH v3 net-next 2/4] rtnetlink: return ENODEV when IFLA_ALT_IFNAME is used in dellink Florent Fourcot
2022-04-05 13:42 ` [PATCH v3 net-next 3/4] rtnetlink: return ENODEV when ifname does not exist and group is given Florent Fourcot
2022-04-06 0:47 ` Jakub Kicinski
2022-04-05 13:42 ` [PATCH v3 net-next 4/4] rtnetlink: return EINVAL when request cannot succeed Florent Fourcot
2022-04-22 3:50 ` Saeed Mahameed
2022-04-22 4:16 ` Eric Dumazet
2022-04-06 0:41 ` [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink Jakub Kicinski
2022-04-07 12:34 ` Florent Fourcot
2022-04-07 16:11 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-04-07 12:25 [PATCH v3 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
2022-04-07 12:25 ` [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407091119.6ff5b879@kernel.org \
--to=kuba@kernel.org \
--cc=brian.baboch@wifirst.fr \
--cc=cong.wang@bytedance.com \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).