Re: [PATCH] rtw89: ser: add a break statement

Nathan Chancellor
2022-04-07T18:01:46Z

On Thu, Apr 07, 2022 at 01:53:49PM -0400, Tom Rix wrote:
> The clang build fails with
> ser.c:397:2: error: unannotated fall-through
> between switch labels [-Werror,-Wimplicit-fallthrough]
> default:
> ^
> The case above the default does not have a break.
> So add one.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

There is also https://lore.kernel.org/r/20220407132316.61132-2-pkshih@realtek.com/.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

I have been using Documentation/process/deprecated.rst as justification
for the extra break, warning aside, as all case statements must end in
one of the following:

break
fallthrough
continue
goto
return

> ---
> drivers/net/wireless/realtek/rtw89/ser.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/ser.c b/drivers/net/wireless/realtek/rtw89/ser.c
> index 25d1df10f226..5aebd6839d29 100644
> --- a/drivers/net/wireless/realtek/rtw89/ser.c
> +++ b/drivers/net/wireless/realtek/rtw89/ser.c
> @@ -394,6 +394,7 @@ static void ser_idle_st_hdl(struct rtw89_ser *ser, u8 evt)
> break;
> case SER_EV_STATE_OUT:
> rtw89_hci_recovery_start(rtwdev);
> + break;
> default:
> break;
> }
> --
> 2.27.0
>