From: Jakub Kicinski <kuba@kernel.org>
To: Coco Li <lixiaoyan@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
willem de bruijn <willemb@google.com>,
Eric Dumazet <edumazet@google.com>,
Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig
Date: Fri, 8 Apr 2022 14:33:49 -0700 [thread overview]
Message-ID: <20220408143349.1e3413eb@kernel.org> (raw)
In-Reply-To: <20220407171554.2712631-1-lixiaoyan@google.com>
On Thu, 7 Apr 2022 10:15:54 -0700 Coco Li wrote:
> XRFM is no longer needed for configuring FOU tunnels
> (CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.
What's the full story? The original code mentions udp_encap_rcv
but would be used to note where that dependency got removed.
> Built and installed kernel and setup GUE/FOU tunnels.
>
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> ---
> net/ipv4/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 87983e70f03f..e983bb0c5012 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
>
> config NET_FOU
> tristate "IP: Foo (IP protocols) over UDP"
> - select XFRM
> select NET_UDP_TUNNEL
> help
> Foo over UDP allows any IP protocol to be directly encapsulated
I think we can also remove the include of xfrm.h from fou.c ?
prev parent reply other threads:[~2022-04-08 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 17:15 [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig Coco Li
2022-04-08 21:33 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408143349.1e3413eb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).