netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig
@ 2022-04-07 17:15 Coco Li
  2022-04-08 21:33 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Coco Li @ 2022-04-07 17:15 UTC (permalink / raw)
  To: David S . Miller, netdev, Jakub Kicinski, Paolo Abeni
  Cc: linux-kernel, willem de bruijn, Eric Dumazet, Greg Thelen,
	Coco Li

XRFM is no longer needed for configuring FOU tunnels
(CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

Built and installed kernel and setup GUE/FOU tunnels.

Signed-off-by: Coco Li <lixiaoyan@google.com>
---
 net/ipv4/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 87983e70f03f..e983bb0c5012 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
 
 config NET_FOU
 	tristate "IP: Foo (IP protocols) over UDP"
-	select XFRM
 	select NET_UDP_TUNNEL
 	help
 	  Foo over UDP allows any IP protocol to be directly encapsulated
-- 
2.35.1.1178.g4f1659d476-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig
  2022-04-07 17:15 [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig Coco Li
@ 2022-04-08 21:33 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-04-08 21:33 UTC (permalink / raw)
  To: Coco Li
  Cc: David S . Miller, netdev, Paolo Abeni, linux-kernel,
	willem de bruijn, Eric Dumazet, Greg Thelen

On Thu,  7 Apr 2022 10:15:54 -0700 Coco Li wrote:
> XRFM is no longer needed for configuring FOU tunnels
> (CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

What's the full story? The original code mentions udp_encap_rcv 
but would be used to note where that dependency got removed.

> Built and installed kernel and setup GUE/FOU tunnels.
> 
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> ---
>  net/ipv4/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 87983e70f03f..e983bb0c5012 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
>  
>  config NET_FOU
>  	tristate "IP: Foo (IP protocols) over UDP"
> -	select XFRM
>  	select NET_UDP_TUNNEL
>  	help
>  	  Foo over UDP allows any IP protocol to be directly encapsulated

I think we can also remove the include of xfrm.h from fou.c ?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-08 21:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-07 17:15 [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig Coco Li
2022-04-08 21:33 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).