From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0253C433F5 for ; Fri, 8 Apr 2022 23:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240092AbiDHXxF (ORCPT ); Fri, 8 Apr 2022 19:53:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236587AbiDHXxE (ORCPT ); Fri, 8 Apr 2022 19:53:04 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06F5FD0A8D; Fri, 8 Apr 2022 16:50:56 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id i27so20164477ejd.9; Fri, 08 Apr 2022 16:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SUqMtItyQZq0VImWzHlQNyf9xOR5YZgjl7HG7ggaASA=; b=nJriARLQYTMhH8chWXt44TKYI93PSDPUJtZYNgzWWUVvzVxPGiCZEEj1or0iOTefo6 cFscWaA85nZ2Y/kClhUqsgDfbrhKPUZDkkzyM5PK+amxjD4B9bkaMfh3UvILoEcBIGVp pD9y/wuXRsQe30azkivrcgDlMms0jSrgpc0B4YRML0nOkZ8W8oa2xa3dmJEJI48q7Lph hERaCN4LvyngWLcE/nNTdaJoURQxBLZ0UWrRoEU5cNkW9BTCN6Tydlp6kYyBV95RnXZw p2O6zP4x77KUbOQ1olKZSBNoc7+rWVjcHZXqzKdeMH9GniNs2g4IkkVS8/3XGbjIDWwo 0yJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SUqMtItyQZq0VImWzHlQNyf9xOR5YZgjl7HG7ggaASA=; b=8DPEZRpXJWWK2l766VV0YM7MbJPzXNZcKhKEtBwwll0TVZ6RXYkEiMUwBqKywHkwId QrULu6Q2HkRO5VL9BZFp5ObTBAKkq4nVdAqrafVV0+KZ0RbijlxbfCjpYKmX9aFofvdl 3TALe/aUsSoZMPs9j3UHlqYrUGSHas2X6OXc5r87siL17KZ4WYyJrco9fEI9DxckRX2e sV/GTb/BtaTIU9JwdaRLmek+JOq/FG7IKh+aCSRJv7EUOSTBRnYcgQy+x3QtLp27Ozdk sEpDnvP/+wUB7rjmzfb5qKqoY5sT/nOToqlQq8ATTFmF8xmb1Y4262FF4DQBpFrGsNaF BSbA== X-Gm-Message-State: AOAM533FUz76f6oZV7KItkI9wr477PfSkyg0kWcuNtCcQx/3Y/14UzAZ tvfiBHtcAB03jqWEF6RxH30= X-Google-Smtp-Source: ABdhPJx48I6qNVXy5JRlDDppagH8Z8UT68EDC0Z1VNqIiGnngdmjei8lBxcmBqvnL8jnUCdrueVd4Q== X-Received: by 2002:a17:906:9c82:b0:6df:baa2:9f75 with SMTP id fj2-20020a1709069c8200b006dfbaa29f75mr20667399ejc.762.1649461854531; Fri, 08 Apr 2022 16:50:54 -0700 (PDT) Received: from skbuf ([188.26.57.45]) by smtp.gmail.com with ESMTPSA id w14-20020a509d8e000000b0041cd217726dsm7443672ede.4.2022.04.08.16.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 16:50:54 -0700 (PDT) Date: Sat, 9 Apr 2022 02:50:51 +0300 From: Vladimir Oltean To: Jakob Koschel Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Florian Fainelli , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Edward Cree , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Casper Andersson , Bjarni Jonasson , Colin Ian King , Michael Walle , Christophe JAILLET , Arnd Bergmann , Eric Dumazet , Di Zhu , Xu Wang , Netdev , LKML , Linux ARM , linuxppc-dev , Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Subject: Re: [PATCH net-next 03/15] net: dsa: mv88e6xxx: Replace usage of found with dedicated iterator Message-ID: <20220408235051.2a4hh7p3lee3a3xv@skbuf> References: <20220407102900.3086255-1-jakobkoschel@gmail.com> <20220407102900.3086255-4-jakobkoschel@gmail.com> <20220408123101.p33jpynhqo67hebe@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Apr 09, 2022 at 01:44:00AM +0200, Jakob Koschel wrote: > > Let's try to not make convoluted code worse. Do the following 2 patches > > achieve what you are looking for? Originally I had a single patch (what > > is now 2/2) but I figured it would be cleaner to break out the unrelated > > change into what is now 1/2. > > I do agree with not making convoluted code worse, but I was reluctant with > e.g. introducing new functions for this because others essentially > have the opposite opinion on this. > > I however like solving it that way, it makes it a lot cleaner. Yeah, I think 'just adapt to the context and style and intentions of the code you're changing and don't try to push a robotic one-size-fits-all solution' is sensible enough for an initial guiding principle. > > If you want I can submit these changes separately. > > Sure if you want to submit them separately, go ahead. Otherwise I can > integrate it into a v2, whatever you prefer essentially. If you're moving quickly feel free to pick them up. I have lots of other things on my backlog so it won't be until late next week until I even consider submitting these.