From: Florian Westphal <fw@strlen.de>
To: Mark Mielke <mark.mielke@gmail.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
Pravin B Shelar <pshelar@ovn.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH] openvswitch: Ensure nf_ct_put is not called with null pointer
Date: Sat, 9 Apr 2022 11:55:33 +0200 [thread overview]
Message-ID: <20220409095533.GB19371@breakpoint.cc> (raw)
In-Reply-To: <20220409094036.20051-1-mark.mielke@gmail.com>
Mark Mielke <mark.mielke@gmail.com> wrote:
> A recent commit replaced calls to nf_conntrack_put() with calls
> to nf_ct_put(). nf_conntrack_put() permitted the caller to pass
> null without side effects, while nf_ct_put() performs WARN_ON()
> and proceeds to try and de-reference the pointer. ovs-vswitchd
> triggers the warning on startup:
>
> [ 22.178881] WARNING: CPU: 69 PID: 2157 at include/net/netfilter/nf_conntrack.h:176 __ovs_ct_lookup+0x4e2/0x6a0 [openvswitch]
> ...
> [ 22.213573] Call Trace:
> [ 22.214318] <TASK>
> [ 22.215064] ovs_ct_execute+0x49c/0x7f0 [openvswitch]
Applied to nf.git, thanks.
next prev parent reply other threads:[~2022-04-09 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 9:40 [PATCH] openvswitch: Ensure nf_ct_put is not called with null pointer Mark Mielke
2022-04-09 9:55 ` Florian Westphal [this message]
2022-04-10 15:41 ` Florian Westphal
2022-04-25 10:36 ` [ovs-dev] " Ilya Maximets
2022-04-25 10:53 ` Florian Westphal
2022-04-25 11:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409095533.GB19371@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=kuba@kernel.org \
--cc=mark.mielke@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).