From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A82FBC433F5 for ; Sat, 9 Apr 2022 10:18:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238151AbiDIKUO (ORCPT ); Sat, 9 Apr 2022 06:20:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234722AbiDIKUN (ORCPT ); Sat, 9 Apr 2022 06:20:13 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 628ED3C487 for ; Sat, 9 Apr 2022 03:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649499486; x=1681035486; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=C6U1V87siRPRZCH9qENMTaYVfRsbKyhnbJtISrGKcOk=; b=cVp1JNTOZq4I+EGFu2mYqTI37YKQ4ti0WgLxuCXO0NVYwdnaLe+VTTvr n08pE3iu8XG9Png4IJf8V5Km1YRUhhzhgYnKoxYUzV1HDePnjhd0EsJhh hr7qBMYazRlaKrBuCNzS5F5qHC77koaZtoPyUdyZIEBp35H/h5ZFv9TdB ScgqKOu8Y6w4Y5VXTvd8VAGaNc+b3KDJzH14wGnWsROkrlMKJ7FTsSQH8 /Yxz0/JupjjGVsiuUktP+gi3cuASYq0FvUKyKz8UWowTWTRzIYIdFf5Ar /vnN03HkrnAojZs6b2XixIrdn1tDJqvPqnAMmEAZe80cmMUG7kkUM2jow w==; X-IronPort-AV: E=McAfee;i="6400,9594,10311"; a="241721293" X-IronPort-AV: E=Sophos;i="5.90,247,1643702400"; d="scan'208";a="241721293" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2022 03:18:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,247,1643702400"; d="scan'208";a="558172370" Received: from lkp-server02.sh.intel.com (HELO 7e80bc2a00a0) ([10.239.97.151]) by fmsmga007.fm.intel.com with ESMTP; 09 Apr 2022 03:18:02 -0700 Received: from kbuild by 7e80bc2a00a0 with local (Exim 4.95) (envelope-from ) id 1nd8AL-00015F-PL; Sat, 09 Apr 2022 10:18:01 +0000 Date: Sat, 9 Apr 2022 18:17:15 +0800 From: kernel test robot To: Vladimir Oltean , netdev@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Jakub Kicinski , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , UNGLinuxDriver@microchip.com, Paolo Abeni , Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Tobias Waldekranz , Mattias Forsblad Subject: Re: [PATCH net-next 6/6] net: bridge: avoid uselessly making offloaded ports promiscuous Message-ID: <202204091856.0PBgeBSa-lkp@intel.com> References: <20220408200337.718067-7-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408200337.718067-7-vladimir.oltean@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Vladimir-Oltean/Disable-host-flooding-for-DSA-ports-under-a-bridge/20220409-041556 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e8bd70250a821edb541c3abe1eacdad9f8dc7adf config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20220409/202204091856.0PBgeBSa-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 893e1c18b98d8bbc7b8d7d22cc2c348f65c72ad9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2b24e24c704fa129c753dbc8fb764c95f4a3562c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vladimir-Oltean/Disable-host-flooding-for-DSA-ports-under-a-bridge/20220409-041556 git checkout 2b24e24c704fa129c753dbc8fb764c95f4a3562c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/bridge/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/bridge/br_if.c:145:10: error: no member named 'offload_count' in 'struct net_bridge_port' if (p->offload_count) { ~ ^ 1 error generated. vim +145 net/bridge/br_if.c 129 130 /* When a port is added or removed or when certain port flags 131 * change, this function is called to automatically manage 132 * promiscuity setting of all the bridge ports. We are always called 133 * under RTNL so can skip using rcu primitives. 134 */ 135 void br_manage_promisc(struct net_bridge *br) 136 { 137 struct net_bridge_port *p; 138 139 list_for_each_entry(p, &br->port_list, list) { 140 /* Offloaded ports have a separate address database for 141 * forwarding, which is managed through switchdev and not 142 * through dev_uc_add(), so the promiscuous concept makes no 143 * sense for them. Avoid updating promiscuity in that case. 144 */ > 145 if (p->offload_count) { 146 br_port_clear_promisc(p); 147 continue; 148 } 149 150 /* If bridge is promiscuous, unconditionally place all ports 151 * in promiscuous mode too. This allows the bridge device to 152 * locally receive all unknown traffic. 153 */ 154 if (br->dev->flags & IFF_PROMISC) { 155 br_port_set_promisc(p); 156 continue; 157 } 158 159 /* If vlan filtering is disabled, place all ports in 160 * promiscuous mode. 161 */ 162 if (!br_vlan_enabled(br->dev)) { 163 br_port_set_promisc(p); 164 continue; 165 } 166 167 /* If the number of auto-ports is <= 1, then all other ports 168 * will have their output configuration statically specified 169 * through fdbs. Since ingress on the auto-port becomes 170 * forwarding/egress to other ports and egress configuration is 171 * statically known, we can say that ingress configuration of 172 * the auto-port is also statically known. 173 * This lets us disable promiscuous mode and write this config 174 * to hw. 175 */ 176 if (br->auto_cnt == 0 || 177 (br->auto_cnt == 1 && br_auto_port(p))) 178 br_port_clear_promisc(p); 179 else 180 br_port_set_promisc(p); 181 } 182 } 183 -- 0-DAY CI Kernel Test Service https://01.org/lkp