From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D77C433F5 for ; Mon, 11 Apr 2022 20:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244842AbiDKUJe (ORCPT ); Mon, 11 Apr 2022 16:09:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244615AbiDKUJc (ORCPT ); Mon, 11 Apr 2022 16:09:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B8F8275C9 for ; Mon, 11 Apr 2022 13:07:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A21B3615B4 for ; Mon, 11 Apr 2022 20:07:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85B69C385A3; Mon, 11 Apr 2022 20:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649707637; bh=akUKc2qMPdmvIzLjRs9PUc2/arBas9GZBjis6mpFz7Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mOBMDviR8AXtuzyyWnn/ZEZ1ozwruiGE0WmlmDKTzEEygB873DSrDhcqGwU8S0S+e kJjoGpLD8leXsSgASmZLBLTplwHzuMl8BK2w8QxYR83M47omOJLTQL8CzSnRgYK7zI HXgSE95ihDME8HKY0rUEb8rZEDHODI8XDZx0qq/RSlJS+fic7cjzLODjQFsft5G9RS nBbTbutiIJ6bK07WDBfZLab3Ih/RVO8OCGwfy4ciqKP9x0GnY9iJr6e2MNKoaHMAxT RVNS5ns9fcmpRaWDOGmhGsnvZh5lDBMGK9TZHNi7c0YH/OUrnC3as2j9+qQIM0tcLB PaiSuX3POf0Aw== Date: Mon, 11 Apr 2022 13:07:15 -0700 From: Jakub Kicinski To: Josua Mayer Cc: Krzysztof Kozlowski , netdev@vger.kernel.org, alvaro.karsz@solid-run.com, Michael Hennerich , "David S. Miller" , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Alexandru Ardelean Subject: Re: [PATCH 1/3] dt: adin: document clk-out property Message-ID: <20220411130715.516fc5cc@kernel.org> In-Reply-To: References: <20220410104626.11517-1-josua@solid-run.com> <20220410104626.11517-2-josua@solid-run.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 11 Apr 2022 10:42:18 +0300 Josua Mayer wrote: > > The binding should describe the hardware, not implementation in Linux, > > therefore you should actually list all possible choices. The driver then > > can just return EINVAL on unsupported choices (or map them back to only > > one supported). =20 >=20 > I have prepared a draft for the entries that should exist, it covers=20 > five of the 6 available bits. Maybe you can comment if this is=20 > understandable? >=20 > =C2=A0 adi,phy-output-clock: > =C2=A0=C2=A0=C2=A0 description: Select clock output on GP_CLK pin. Three= clocks are=20 > available: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 A 25MHz reference, a free-running 125MHz = and a recovered 125MHz. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 The phy can also automatically switch bet= ween the reference and the > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 respective 125MHz clocks based on its int= ernal state. > =C2=A0=C2=A0=C2=A0 $ref: /schemas/types.yaml#/definitions/string > =C2=A0=C2=A0=C2=A0 enum: > =C2=A0=C2=A0=C2=A0 - 25mhz-reference > =C2=A0=C2=A0=C2=A0 - 125mhz-free-running > =C2=A0=C2=A0=C2=A0 - 125mhz-recovered > =C2=A0=C2=A0=C2=A0 - adaptive-free-running > =C2=A0=C2=A0=C2=A0 - adaptive-recovered >=20 > Bit no. 3 (GE_REF_CLK_EN) is special in that it can be enabled=20 > independently from the 5 choices above, > and it controls a different pin. Therefore it deserves its own property,= =20 > perhaps a flag or boolean adi,phy-output-ref-clock. > Any opinion if this should be added, or we can omit it completely? Noob question - can you explain how this property describes HW? I thought we had a framework for clock config, and did not require vendor specific properties of this sort. The recovered vs free running makes the entire thing sound like a SyncE related knob, irrelevant to normal HW operation.