From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B648C433EF for ; Tue, 12 Apr 2022 10:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350477AbiDLKFw (ORCPT ); Tue, 12 Apr 2022 06:05:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343901AbiDLJAS (ORCPT ); Tue, 12 Apr 2022 05:00:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E66D315708; Tue, 12 Apr 2022 01:15:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 64C35B81B76; Tue, 12 Apr 2022 08:15:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AC35C385A8; Tue, 12 Apr 2022 08:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649751303; bh=NQjXyMGVp6+C0UwowNnJIzpOMvx2ZN0GwcrTxKcb1lQ=; h=From:To:Cc:Subject:Date:From; b=WNGRtZEEX4BwRZV84heEIQuYLkTHuIfYkrxj23mwH2scSSnxdBzuLpkpUW5nHd+RA rbgQsIyAb4rlav2oC7/SYE80Ywidigj4Bmsp2DSE/ONxE5dt98Ksrs3nc/f7jbE7NK 3jRT2hZ31ANTQxFak0ujIpc/OMf2lbI9rZaoSGk9TiTHVMGc31Cz4eEyxw/Pnj7vGJ x5cryOWL4tPCl9i4DbLGCviNJFmRy4djcX/q3EHrDp3apeo6UAR1uX0E8qDYsYmFoB x0GlSOmGHR3fbq/a0CsntAlQ+EDBI1Oh57gFt9CbD40XGJDZ89EFKc3z6mUuc5T73z 5zSh8x0Li9IrA== From: Antoine Tenart To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de Cc: Antoine Tenart , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH nf] netfilter: nf_tables: nft_parse_register can return a negative value Date: Tue, 12 Apr 2022 10:14:59 +0200 Message-Id: <20220412081459.263276-1-atenart@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since commit 6e1acfa387b9 ("netfilter: nf_tables: validate registers coming from userspace.") nft_parse_register can return a negative value, but the function prototype is still returning an unsigned int. Fixes: 6e1acfa387b9 ("netfilter: nf_tables: validate registers coming from userspace.") Cc: Pablo Neira Ayuso Signed-off-by: Antoine Tenart --- net/netfilter/nf_tables_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 128ee3b300d6..16c3a39689f4 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -9363,7 +9363,7 @@ int nft_parse_u32_check(const struct nlattr *attr, int max, u32 *dest) } EXPORT_SYMBOL_GPL(nft_parse_u32_check); -static unsigned int nft_parse_register(const struct nlattr *attr, u32 *preg) +static int nft_parse_register(const struct nlattr *attr, u32 *preg) { unsigned int reg; -- 2.35.1