From: Jakub Kicinski <kuba@kernel.org>
To: Ray Jui <ray.jui@broadcom.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC] Applicability of using 'txq_trans_update' during ring recovery
Date: Tue, 12 Apr 2022 10:37:24 -0700 [thread overview]
Message-ID: <20220412103724.54924945@kernel.org> (raw)
In-Reply-To: <1bdb8417-233d-932b-1dc0-c56042aedabd@broadcom.com>
On Tue, 12 Apr 2022 10:01:02 -0700 Ray Jui wrote:
> Hi David/Jakub,
>
> I'd like to run through you on the idea of invoking 'txq_trans_update'
> to update the last TX timestamp in the scenario where we temporarily
> stop the TX queue to do some recovery work. Is it considered an
> acceptable approach to prevent false positive triggering of TX timeout
> during the recovery process?
>
> I know in general people use 'netif_carrier_off' during the process when
> they reset/change the entire TX/RX ring set and/or other resources on
> the Ethernet card. But in our particular case, we have another driver
> running (i.e., RoCE) on top and setting 'netif_carrier_off' will cause a
> significant side effect on the other driver (e.g., all RoCE QPs will be
> terminated). In addition, for this special recovery work on our driver,
> we are doing it on a per NAPI ring set basis while keeping the traffic
> on other queues running. Using 'netif_carrier_off' will prevent traffic
> running from all other queues that are not going through recovery.
Can you use netif_device_detach() to mark the device as not present?
next prev parent reply other threads:[~2022-04-12 17:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 17:01 [RFC] Applicability of using 'txq_trans_update' during ring recovery Ray Jui
2022-04-12 17:37 ` Jakub Kicinski [this message]
2022-04-12 18:08 ` Ray Jui
2022-04-12 18:24 ` Michael Chan
2022-04-12 18:36 ` Ray Jui
2022-04-12 19:19 ` Michael Chan
2022-04-12 19:34 ` Ray Jui
2022-04-12 21:49 ` Jakub Kicinski
2022-04-12 22:21 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412103724.54924945@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).