From: Andrea Parri <parri.andrea@gmail.com>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Stefano Garzarella <sgarzare@redhat.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 5/6] Drivers: hv: vmbus: Accept hv_sock offers in isolated guests
Date: Fri, 15 Apr 2022 08:58:47 +0200 [thread overview]
Message-ID: <20220415065847.GD2961@anparri> (raw)
In-Reply-To: <PH0PR21MB302520562EED77A587340D1DD7EE9@PH0PR21MB3025.namprd21.prod.outlook.com>
> > @@ -976,17 +976,22 @@ find_primary_channel_by_offer(const struct
> > vmbus_channel_offer_channel *offer)
> > return channel;
> > }
> >
> > -static bool vmbus_is_valid_device(const guid_t *guid)
> > +static bool vmbus_is_valid_offer(const struct vmbus_channel_offer_channel *offer)
> > {
> > + const guid_t *guid = &offer->offer.if_type;
> > u16 i;
> >
> > if (!hv_is_isolation_supported())
> > return true;
> >
> > + if (is_hvsock_offer(offer))
> > + return true;
> > +
> > for (i = 0; i < ARRAY_SIZE(vmbus_devs); i++) {
> > if (guid_equal(guid, &vmbus_devs[i].guid))
> > return vmbus_devs[i].allowed_in_isolated;
> > }
> > +
>
> Spurious newline added?
>
> > return false;
Intentionally added to visually separate the "hvsock", "vmbus_dev" and
"default" blocks, patch seemed simple enough to try to merge in "style
material" without incurring in the question. ;-)
Newline removed.
Thanks,
Andrea
next prev parent reply other threads:[~2022-04-15 6:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 20:47 [RFC PATCH 0/6] hv_sock: Hardening changes Andrea Parri (Microsoft)
2022-04-13 20:47 ` [RFC PATCH 1/6] hv_sock: Check hv_pkt_iter_first_raw()'s return value Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:41 ` Andrea Parri
2022-04-15 14:27 ` Michael Kelley (LINUX)
2022-04-15 16:09 ` Andrea Parri
2022-04-13 20:47 ` [RFC PATCH 2/6] hv_sock: Copy packets sent by Hyper-V out of the ring buffer Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:42 ` Andrea Parri
2022-04-13 20:47 ` [RFC PATCH 3/6] hv_sock: Add validation for untrusted Hyper-V values Andrea Parri (Microsoft)
2022-04-13 20:47 ` [RFC PATCH 4/6] hv_sock: Initialize send_buf in hvs_stream_enqueue() Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:50 ` Andrea Parri
2022-04-15 14:30 ` Michael Kelley (LINUX)
2022-04-15 16:16 ` Andrea Parri
2022-04-13 20:47 ` [RFC PATCH 5/6] Drivers: hv: vmbus: Accept hv_sock offers in isolated guests Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:58 ` Andrea Parri [this message]
2022-04-13 20:47 ` [RFC PATCH 6/6] Drivers: hv: vmbus: Refactor the ring-buffer iterator functions Andrea Parri (Microsoft)
2022-04-15 3:34 ` Michael Kelley (LINUX)
2022-04-15 7:00 ` Andrea Parri
2022-04-15 16:28 ` Andrea Parri
2022-04-15 16:44 ` Michael Kelley (LINUX)
2022-04-15 17:05 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415065847.GD2961@anparri \
--to=parri.andrea@gmail.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).