From: Stephen Hemminger <stephen@networkplumber.org>
To: Florent Fourcot <florent.fourcot@wifirst.fr>
Cc: netdev@vger.kernel.org, cong.wang@bytedance.com,
edumazet@google.com, Brian Baboch <brian.baboch@wifirst.fr>
Subject: Re: [PATCH v5 net-next 4/4] rtnetlink: return EINVAL when request cannot succeed
Date: Fri, 15 Apr 2022 12:26:01 -0700 [thread overview]
Message-ID: <20220415122601.0b793cb9@hermes.local> (raw)
In-Reply-To: <20220415165330.10497-5-florent.fourcot@wifirst.fr>
On Fri, 15 Apr 2022 18:53:30 +0200
Florent Fourcot <florent.fourcot@wifirst.fr> wrote:
> A request without interface name/interface index/interface group cannot
> work. We should return EINVAL
>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
> Signed-off-by: Brian Baboch <brian.baboch@wifirst.fr>
> ---
> net/core/rtnetlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 73f2cbc440c9..b943336908a7 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -3457,7 +3457,7 @@ static int __rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
> return rtnl_group_changelink(skb, net,
> nla_get_u32(tb[IFLA_GROUP]),
> ifm, extack, tb);
> - return -ENODEV;
> + return -EINVAL;
Sometimes changing errno can be viewed as ABI change and break applications.
next prev parent reply other threads:[~2022-04-15 19:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 16:53 [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 1/4] rtnetlink: return ENODEV when ifname does not exist and group is given Florent Fourcot
2022-04-15 19:24 ` Stephen Hemminger
2022-04-19 7:29 ` Florent Fourcot
2022-04-19 15:04 ` Stephen Hemminger
2022-04-15 16:53 ` [PATCH v5 net-next 2/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 3/4] rtnetlink: return ENODEV when IFLA_ALT_IFNAME is used in dellink Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 4/4] rtnetlink: return EINVAL when request cannot succeed Florent Fourcot
2022-04-15 19:26 ` Stephen Hemminger [this message]
2022-04-19 7:29 ` Florent Fourcot
2022-04-22 1:27 ` Vinicius Costa Gomes
2022-04-15 19:03 ` [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Jakub Kicinski
2022-04-19 11:50 ` patchwork-bot+netdevbpf
2022-04-19 11:50 ` Jason A. Donenfeld
2022-04-19 12:51 ` [PATCH net-next] Revert "rtnetlink: return EINVAL when request cannot succeed" Florent Fourcot
2022-04-20 14:48 ` Guillaume Nault
2022-04-21 1:15 ` Eric Dumazet
2022-04-22 10:10 ` patchwork-bot+netdevbpf
2022-04-19 14:25 ` [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415122601.0b793cb9@hermes.local \
--to=stephen@networkplumber.org \
--cc=brian.baboch@wifirst.fr \
--cc=cong.wang@bytedance.com \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).