From: Stephen Hemminger <stephen@networkplumber.org>
To: Florent Fourcot <florent.fourcot@wifirst.fr>
Cc: netdev@vger.kernel.org, cong.wang@bytedance.com,
edumazet@google.com, Brian Baboch <brian.baboch@wifirst.fr>
Subject: Re: [PATCH v5 net-next 1/4] rtnetlink: return ENODEV when ifname does not exist and group is given
Date: Tue, 19 Apr 2022 08:04:15 -0700 [thread overview]
Message-ID: <20220419080415.718913e0@hermes.local> (raw)
In-Reply-To: <d63921e9-2306-a153-48fe-a1f65157aafa@wifirst.fr>
On Tue, 19 Apr 2022 09:29:37 +0200
Florent Fourcot <florent.fourcot@wifirst.fr> wrote:
> Hello,
>
>
> >> + if (link_specified)
> >> + return -ENODEV;
> >
> > Please add extack error message as well?
> > Simple errno's are harder to debug.
>
>
> What kind of message have you in mind for that one? Something like
> "Interface not found" does not have extra information for ENODEV code.
>
> At this place, one gave interface index or interface name, and nothing
> matched.
Not sure how code gets here. Maybe "interface name required"
next prev parent reply other threads:[~2022-04-19 15:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 16:53 [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 1/4] rtnetlink: return ENODEV when ifname does not exist and group is given Florent Fourcot
2022-04-15 19:24 ` Stephen Hemminger
2022-04-19 7:29 ` Florent Fourcot
2022-04-19 15:04 ` Stephen Hemminger [this message]
2022-04-15 16:53 ` [PATCH v5 net-next 2/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 3/4] rtnetlink: return ENODEV when IFLA_ALT_IFNAME is used in dellink Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 4/4] rtnetlink: return EINVAL when request cannot succeed Florent Fourcot
2022-04-15 19:26 ` Stephen Hemminger
2022-04-19 7:29 ` Florent Fourcot
2022-04-22 1:27 ` Vinicius Costa Gomes
2022-04-15 19:03 ` [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Jakub Kicinski
2022-04-19 11:50 ` patchwork-bot+netdevbpf
2022-04-19 11:50 ` Jason A. Donenfeld
2022-04-19 12:51 ` [PATCH net-next] Revert "rtnetlink: return EINVAL when request cannot succeed" Florent Fourcot
2022-04-20 14:48 ` Guillaume Nault
2022-04-21 1:15 ` Eric Dumazet
2022-04-22 10:10 ` patchwork-bot+netdevbpf
2022-04-19 14:25 ` [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419080415.718913e0@hermes.local \
--to=stephen@networkplumber.org \
--cc=brian.baboch@wifirst.fr \
--cc=cong.wang@bytedance.com \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).