From: Bjorn Helgaas <helgaas@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h
Date: Tue, 19 Apr 2022 09:23:10 -0500 [thread overview]
Message-ID: <20220419142310.GA1197793@bhelgaas> (raw)
In-Reply-To: <1650362568-11119-1-git-send-email-yinjun.zhang@corigine.com>
On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
I'd be happy to apply this, but since I'm in the cc: line, I assume it
will be applied with other patches that use this. Let me know if
otherwise.
I see that you also added the ID at
https://pci-ids.ucw.cz/read/PC/1da8; thank you for that!
But it looks like the "name" part isn't quite correct -- at
https://pci-ids.ucw.cz/read/PC?restrict=1, "Corigine" isn't shown, so
I think lspci won't show the right thing yet.
> ---
> include/linux/pci_ids.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 0178823ce8c2..6d12b6d71c61 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2568,6 +2568,8 @@
>
> #define PCI_VENDOR_ID_HYGON 0x1d94
>
> +#define PCI_VENDOR_ID_CORIGINE 0x1da8
> +
> #define PCI_VENDOR_ID_FUNGIBLE 0x1dad
>
> #define PCI_VENDOR_ID_HXT 0x1dbf
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2022-04-19 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 10:02 [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h Yinjun Zhang
2022-04-19 14:23 ` Bjorn Helgaas [this message]
2022-04-20 1:46 ` Yinjun Zhang
2022-04-19 22:00 ` Andrew Lunn
2022-04-20 1:59 ` Yinjun Zhang
2022-04-20 6:12 ` Leon Romanovsky
2022-04-20 7:42 ` Yinjun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419142310.GA1197793@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).