From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A9DC4332F for ; Tue, 19 Apr 2022 18:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356905AbiDSSYv (ORCPT ); Tue, 19 Apr 2022 14:24:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357061AbiDSSWj (ORCPT ); Tue, 19 Apr 2022 14:22:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDFEC3E5FB; Tue, 19 Apr 2022 11:15:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95B9A61444; Tue, 19 Apr 2022 18:15:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40283C385A7; Tue, 19 Apr 2022 18:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650392109; bh=w0FGOCu0HGhfsf/vHWDXhezZ4vO/9mPGexCH8WeywMg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UtcBsQga0uFlfFlWRZ+vYn0zgbY4tbnIuspzcElnHzfhD+8H7sFfbO0trOCkKszHv e5rhQ9W5DTNn0oe6A85ujV0xY0IbE6g497311ISJx5yVJkYX0zr0/+69rCrFiU2IdQ FMuEOKYTVmBmFxKEVnEebw/fLFRuCibG/4CRU4YK7jrcD3lcxZjpRd2as44p7M7/q1 CQXh5trHUcBo7fGlgck310ckB5xoRa+ARP9P94ERw+TCBxp0qDc4PQdlOWVdhxRhj7 O0gbXxw4oH5OaYqI+46t/ywottNmnXref3uINVdHgZJO66CxQKsF2YPCUHYs9L9cZo +gYiQDN17nxQw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Borislav Petkov , Borislav Petkov , Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "David S. Miller" , Jakub Kicinski , brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, Arend van Spriel , Sasha Levin , pabeni@redhat.com, hdegoede@redhat.com, mbrugger@suse.com, wsa+renesas@sang-engineering.com, marcan@marcan.st, linus.walleij@linaro.org, angus@akkea.ca, mike.rudenko@gmail.com, linux-wireless@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com Subject: [PATCH AUTOSEL 5.4 08/14] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant Date: Tue, 19 Apr 2022 14:14:37 -0400 Message-Id: <20220419181444.485959-8-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220419181444.485959-1-sashal@kernel.org> References: <20220419181444.485959-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Borislav Petkov [ Upstream commit 6fb3a5868b2117611f41e421e10e6a8c2a13039a ] Fix: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17): ^~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13): ^~~~ See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory details as to why it triggers with older gccs only. Signed-off-by: Borislav Petkov Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: brcm80211-dev-list.pdl@broadcom.com Cc: netdev@vger.kernel.org Acked-by: Arend van Spriel Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/Ykx0iRlvtBnKqtbG@zn.tnic Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index ef5521b9b357..ddc999670484 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -550,7 +550,7 @@ enum brcmf_sdio_frmtype { BRCMF_SDIO_FT_SUB, }; -#define SDIOD_DRVSTR_KEY(chip, pmu) (((chip) << 16) | (pmu)) +#define SDIOD_DRVSTR_KEY(chip, pmu) (((unsigned int)(chip) << 16) | (pmu)) /* SDIO Pad drive strength to select value mappings */ struct sdiod_drive_str { -- 2.35.1