From: Pavel Pisa <pisa@cmp.felk.cvut.cz>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: ondrej.ille@gmail.com, wg@grandegger.com, mkl@pengutronix.de,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] can: ctucanfd: Remove unused including <linux/version.h>
Date: Thu, 21 Apr 2022 23:17:07 +0200 [thread overview]
Message-ID: <202204212317.07635.pisa@cmp.felk.cvut.cz> (raw)
In-Reply-To: <20220421202852.2693-1-jiapeng.chong@linux.alibaba.com>
Thanks for checking
On Thursday 21 of April 2022 22:28:52 Jiapeng Chong wrote:
> Eliminate the follow versioncheck warning:
>
> ./drivers/net/can/ctucanfd/ctucanfd_base.c: 34 linux/version.h not
> needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Pave Pisa <pisa@cmp.felk.cvut.cz>
> ---
> drivers/net/can/ctucanfd/ctucanfd_base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/can/ctucanfd/ctucanfd_base.c
> b/drivers/net/can/ctucanfd/ctucanfd_base.c index 7a4550f60abb..be90136be442
> 100644
> --- a/drivers/net/can/ctucanfd/ctucanfd_base.c
> +++ b/drivers/net/can/ctucanfd/ctucanfd_base.c
> @@ -31,7 +31,6 @@
> #include <linux/can/error.h>
> #include <linux/can/led.h>
> #include <linux/pm_runtime.h>
> -#include <linux/version.h>
>
> #include "ctucanfd.h"
> #include "ctucanfd_kregs.h"
--
Yours sincerely
Pavel Pisa
phone: +420 603531357
e-mail: pisa@cmp.felk.cvut.cz
Department of Control Engineering FEE CVUT
Karlovo namesti 13, 121 35, Prague 2
university: http://control.fel.cvut.cz/
personal: http://cmp.felk.cvut.cz/~pisa
projects: https://www.openhub.net/accounts/ppisa
CAN related:http://canbus.pages.fel.cvut.cz/
Open Technologies Research Education and Exchange Services
https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
prev parent reply other threads:[~2022-04-21 21:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 20:28 [PATCH] can: ctucanfd: Remove unused including <linux/version.h> Jiapeng Chong
2022-04-21 21:17 ` Pavel Pisa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204212317.07635.pisa@cmp.felk.cvut.cz \
--to=pisa@cmp.felk.cvut.cz \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pabeni@redhat.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox