From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: generalize skb freeing deferral to per-cpu lists
Date: Fri, 22 Apr 2022 10:10:45 -0700 [thread overview]
Message-ID: <20220422101045.352eb086@kernel.org> (raw)
In-Reply-To: <CANn89iLK5i9y5=iAHS=8+SinGkmGgEXR=xk=ATpnXPakD1j-vQ@mail.gmail.com>
On Fri, 22 Apr 2022 09:50:33 -0700 Eric Dumazet wrote:
> The thing is that with a typical number of RX queues (typically 16 or
> 32 queues on a 100Gbit NIC),
> there is enough sharding for this spinlock to be a non-issue.
>
> Also, we could quite easily add some batching in a future patch, for
> the cases where the number of RX queues
> is too small.
>
> (Each cpu could hold up to 8 or 16 skbs in a per-cpu cache, before
> giving them back to alloc_cpu(s))
I was wondering if we want to keep the per-socket queue for the
batching but you're right, per CPU batch is better anyway if needed.
next prev parent reply other threads:[~2022-04-22 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 15:39 [PATCH net-next] net: generalize skb freeing deferral to per-cpu lists Eric Dumazet
2022-04-22 9:02 ` Paolo Abeni
2022-04-22 15:59 ` Eric Dumazet
2022-04-22 16:40 ` Jakub Kicinski
2022-04-22 16:50 ` Eric Dumazet
2022-04-22 17:10 ` Jakub Kicinski [this message]
2022-04-22 17:25 ` Eric Dumazet
2022-04-22 16:40 ` Jakub Kicinski
2022-04-22 16:50 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422101045.352eb086@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).