From: Jakub Kicinski <kuba@kernel.org>
To: Pengcheng Yang <yangpc@wangsu.com>
Cc: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v3] tcp: ensure to use the most recently sent skb when filling the rate sample
Date: Fri, 22 Apr 2022 13:37:12 -0700 [thread overview]
Message-ID: <20220422133712.17eebbcb@kernel.org> (raw)
In-Reply-To: <1650422081-22153-1-git-send-email-yangpc@wangsu.com>
On Wed, 20 Apr 2022 10:34:41 +0800 Pengcheng Yang wrote:
> If an ACK (s)acks multiple skbs, we favor the information
> from the most recently sent skb by choosing the skb with
> the highest prior_delivered count. But in the interval
> between receiving ACKs, we send multiple skbs with the same
> prior_delivered, because the tp->delivered only changes
> when we receive an ACK.
>
> We used RACK's solution, copying tcp_rack_sent_after() as
> tcp_skb_sent_after() helper to determine "which packet was
> sent last?". Later, we will use tcp_skb_sent_after() instead
> in RACK.
>
> Fixes: b9f64820fb22 ("tcp: track data delivery rate for a TCP connection")
> Signed-off-by: Pengcheng Yang <yangpc@wangsu.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> Cc: Paolo Abeni <pabeni@redhat.com>
Somehow this patch got marked as archived in patchwork. Reviving it now.
Eric, Neal, ack?
next prev parent reply other threads:[~2022-04-22 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 2:34 [PATCH net v3] tcp: ensure to use the most recently sent skb when filling the rate sample Pengcheng Yang
2022-04-22 20:37 ` Jakub Kicinski [this message]
2022-04-22 20:56 ` Neal Cardwell
2022-04-22 21:06 ` Eric Dumazet
2022-04-22 22:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422133712.17eebbcb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangpc@wangsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).