* [PATCH] net: phy: marvell10g: fix return value on error
@ 2022-04-25 6:27 Baruch Siach
2022-04-25 8:57 ` Marek Behún
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Baruch Siach @ 2022-04-25 6:27 UTC (permalink / raw)
To: Russell King, Marek Behún; +Cc: netdev, Baruch Siach
From: Baruch Siach <baruch.siach@siklu.com>
Return back the error value that we get from phy_read_mmd().
Fixes: c84786fa8f91 ("net: phy: marvell10g: read copper results from CSSR1")
Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
---
drivers/net/phy/marvell10g.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
index b6fea119fe13..2b7d0720720b 100644
--- a/drivers/net/phy/marvell10g.c
+++ b/drivers/net/phy/marvell10g.c
@@ -880,7 +880,7 @@ static int mv3310_read_status_copper(struct phy_device *phydev)
cssr1 = phy_read_mmd(phydev, MDIO_MMD_PCS, MV_PCS_CSSR1);
if (cssr1 < 0)
- return val;
+ return cssr1;
/* If the link settings are not resolved, mark the link down */
if (!(cssr1 & MV_PCS_CSSR1_RESOLVED)) {
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: phy: marvell10g: fix return value on error
2022-04-25 6:27 [PATCH] net: phy: marvell10g: fix return value on error Baruch Siach
@ 2022-04-25 8:57 ` Marek Behún
2022-04-25 15:34 ` Russell King (Oracle)
2022-04-26 10:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Marek Behún @ 2022-04-25 8:57 UTC (permalink / raw)
To: Baruch Siach; +Cc: Russell King, netdev, Baruch Siach
On Mon, 25 Apr 2022 09:27:38 +0300
Baruch Siach <baruch@tkos.co.il> wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> Return back the error value that we get from phy_read_mmd().
>
> Fixes: c84786fa8f91 ("net: phy: marvell10g: read copper results from CSSR1")
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
Reviewed-by: Marek Behún <kabel@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: phy: marvell10g: fix return value on error
2022-04-25 6:27 [PATCH] net: phy: marvell10g: fix return value on error Baruch Siach
2022-04-25 8:57 ` Marek Behún
@ 2022-04-25 15:34 ` Russell King (Oracle)
2022-04-26 10:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2022-04-25 15:34 UTC (permalink / raw)
To: Baruch Siach; +Cc: Marek Behún, netdev, Baruch Siach
On Mon, Apr 25, 2022 at 09:27:38AM +0300, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> Return back the error value that we get from phy_read_mmd().
>
> Fixes: c84786fa8f91 ("net: phy: marvell10g: read copper results from CSSR1")
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: phy: marvell10g: fix return value on error
2022-04-25 6:27 [PATCH] net: phy: marvell10g: fix return value on error Baruch Siach
2022-04-25 8:57 ` Marek Behún
2022-04-25 15:34 ` Russell King (Oracle)
@ 2022-04-26 10:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-26 10:00 UTC (permalink / raw)
To: Baruch Siach; +Cc: linux, kabel, netdev, baruch.siach
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 25 Apr 2022 09:27:38 +0300 you wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> Return back the error value that we get from phy_read_mmd().
>
> Fixes: c84786fa8f91 ("net: phy: marvell10g: read copper results from CSSR1")
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
>
> [...]
Here is the summary with links:
- net: phy: marvell10g: fix return value on error
https://git.kernel.org/netdev/net/c/0ed9704b660b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-26 10:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-25 6:27 [PATCH] net: phy: marvell10g: fix return value on error Baruch Siach
2022-04-25 8:57 ` Marek Behún
2022-04-25 15:34 ` Russell King (Oracle)
2022-04-26 10:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).