netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Boris Sukholitko <boris.sukholitko@broadcom.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
	Ilya Lifshits <ilya.lifshits@broadcom.com>
Subject: Re: [PATCH iproute2-next v3 0/2] f_flower: match on the number of vlan tags
Date: Tue, 26 Apr 2022 08:11:42 -0700	[thread overview]
Message-ID: <20220426081142.71d58c1b@hermes.local> (raw)
In-Reply-To: <20220426091417.7153-1-boris.sukholitko@broadcom.com>

On Tue, 26 Apr 2022 12:14:15 +0300
Boris Sukholitko <boris.sukholitko@broadcom.com> wrote:

> Hi,
> 
> Our customers in the fiber telecom world have network configurations
> where they would like to control their traffic according to the number
> of tags appearing in the packet.
> 
> For example, TR247 GPON conformance test suite specification mostly
> talks about untagged, single, double tagged packets and gives lax
> guidelines on the vlan protocol vs. number of vlan tags.
> 
> This is different from the common IT networks where 802.1Q and 802.1ad
> protocols are usually describe single and double tagged packet. GPON
> configurations that we work with have arbitrary mix the above protocols
> and number of vlan tags in the packet.
> 
> The following patch series implement number of vlans flower filter. They
> add num_of_vlans flower filter as an alternative to vlan ethtype protocol
> matching. The end result is that the following command becomes possible:
> 
> tc filter add dev eth1 ingress flower \
>   num_of_vlans 1 vlan_prio 5 action drop
> 
> Also, from our logs, we have redirect rules such that:
> 
> tc filter add dev $GPON ingress flower num_of_vlans $N \
>      action mirred egress redirect dev $DEV
> 
> where N can range from 0 to 3 and $DEV is the function of $N.
> 
> Also there are rules setting skb mark based on the number of vlans:
> 
> tc filter add dev $GPON ingress flower num_of_vlans $N vlan_prio \
>     $P action skbedit mark $M
> 
> Thanks,
> Boris.
> 
> - v3: rebased to the latest iproute2-next
> - v2: add missing f_flower subject prefix
> 
> Boris Sukholitko (2):
>   f_flower: Add num of vlans parameter
>   f_flower: Check args with num_of_vlans
> 
>  tc/f_flower.c | 57 ++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 41 insertions(+), 16 deletions(-)

Can you do this with BPF? instead of kernel change?

  parent reply	other threads:[~2022-04-26 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  9:14 [PATCH iproute2-next v3 0/2] f_flower: match on the number of vlan tags Boris Sukholitko
2022-04-26  9:14 ` [PATCH iproute2-next v3 1/2] f_flower: Add num of vlans parameter Boris Sukholitko
2022-04-26  9:14 ` [PATCH iproute2-next v3 2/2] f_flower: Check args with num_of_vlans Boris Sukholitko
2022-04-26 15:11 ` Stephen Hemminger [this message]
2022-04-27 14:32   ` [PATCH iproute2-next v3 0/2] f_flower: match on the number of vlan tags Boris Sukholitko
2022-04-27 16:01     ` Stephen Hemminger
2022-04-28  2:20 ` David Ahern
2022-04-28  8:37   ` Boris Sukholitko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220426081142.71d58c1b@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=boris.sukholitko@broadcom.com \
    --cc=dsahern@kernel.org \
    --cc=ilya.lifshits@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).