From: Jakub Kicinski <kuba@kernel.org>
To: Min Li <min.li.xe@renesas.com>
Cc: richardcochran@gmail.com, lee.jones@linaro.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support
Date: Tue, 26 Apr 2022 14:21:50 -0700 [thread overview]
Message-ID: <20220426142150.47b057a3@kernel.org> (raw)
In-Reply-To: <1651001574-32457-1-git-send-email-min.li.xe@renesas.com>
On Tue, 26 Apr 2022 15:32:53 -0400 Min Li wrote:
> Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY
> for gettime and settime exclusively
Does not build on 32 bit.
> -/*
> +/**
> * Maximum absolute value for write phase offset in picoseconds
> *
> + * @channel: channel
> + * @delta_ns: delta in nanoseconds
> + *
Not a proper kdoc, first line must include struct name or function name.
Please wait 24h with reposting fixed version so other feedback has a
chance to come in.
next prev parent reply other threads:[~2022-04-26 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 19:32 [PATCH net 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support Min Li
2022-04-26 19:32 ` [PATCH net 2/2] ptp: ptp_clockmatrix: return -EBUSY if phase pull-in is in progress Min Li
2022-04-26 21:26 ` Richard Cochran
2022-04-26 21:21 ` Jakub Kicinski [this message]
2022-04-27 14:32 ` [PATCH net 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support Min Li
2022-04-27 15:55 ` Jakub Kicinski
2022-04-26 21:25 ` Richard Cochran
2022-04-27 2:44 ` kernel test robot
2022-04-27 4:46 ` kernel test robot
2022-04-27 8:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426142150.47b057a3@kernel.org \
--to=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).