From: Jakub Kicinski <kuba@kernel.org>
To: "Maloszewski, Michal" <michal.maloszewski@intel.com>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sassmann@redhat.com" <sassmann@redhat.com>,
Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>,
"Jankowski, Konrad0" <konrad0.jankowski@intel.com>
Subject: Re: [PATCH net 1/2] iavf: Fix error when changing ring parameters on ice PF
Date: Thu, 28 Apr 2022 11:28:20 -0700 [thread overview]
Message-ID: <20220428112820.4f36b5e6@kernel.org> (raw)
In-Reply-To: <BL1PR11MB5430A4AD0469C1C4BDCBB5C486FD9@BL1PR11MB5430.namprd11.prod.outlook.com>
On Thu, 28 Apr 2022 18:10:49 +0000 Maloszewski, Michal wrote:
>> Can't we wait for the device to get into the right state?
>> Throwing EAGAIN back to user space is not very friendly.
>
> When we have state which is running, it does not mean that we have
> queues configured on PF. So in order to configure queues on PF, the
> IAVF_FLAG_QUEUES has to be disabled. I use here EAGAIN, because as
> long as we are not configured with queues, it does not make any sense
> to trigger command and we are not sure when the configuration of
> queues will end - so that is why EAGAIN is used.
Let me rephrase the question. Does getting out of the state where error
is reported require user to change something, or is it something that
happens automatically behind the scenes (i.e. the state is transient).
next prev parent reply other threads:[~2022-04-28 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 17:26 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-04-20 Tony Nguyen
2022-04-20 17:26 ` [PATCH net 1/2] iavf: Fix error when changing ring parameters on ice PF Tony Nguyen
2022-04-22 22:47 ` Jakub Kicinski
2022-04-28 18:10 ` Maloszewski, Michal
2022-04-28 18:28 ` Jakub Kicinski [this message]
2022-04-29 13:14 ` Maloszewski, Michal
2022-04-29 17:57 ` Jakub Kicinski
2022-05-09 15:25 ` Maloszewski, Michal
2022-04-20 17:26 ` [PATCH net 2/2] i40e: i40e_main: fix a missing check on list iterator Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428112820.4f36b5e6@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=konrad0.jankowski@intel.com \
--cc=michal.maloszewski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sassmann@redhat.com \
--cc=sylwesterx.dziedziuch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).