From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2829CC433F5 for ; Thu, 28 Apr 2022 17:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350456AbiD1Raj (ORCPT ); Thu, 28 Apr 2022 13:30:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350475AbiD1Raa (ORCPT ); Thu, 28 Apr 2022 13:30:30 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC8D03C495 for ; Thu, 28 Apr 2022 10:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651166834; x=1682702834; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=q1y7Ae5EPviSFqqZquzR7d224n9q5hZDAAZzkZYyj7U=; b=gSSZwXdL5sv8B1LioXqBl8P0MGyotNUVEQaMzF4g7XVvbfHB5FXTs6HT R3bOjKJ+ndkSSXG624YQLnKk5z8o2dxi0/RLdcCUUe5xG8Bw86MMfGiF+ 8DWplcuqb7wd+ttxN1fdEBcQX8dt0dKtsf40diXw9W8NIsSpjG4yq6a4p IyeZgqECXEgWsT/msRqIq2t8spiRPWg51EQbxYOMZcyWdokvDYKCeNHSJ ttHw4JKsCuSRRU1qWDqiYWVkn7UvbyACn0i9mVvfszVa5uu1YuRTB5Ljb 1rYfdlqCfuq1DRHd6A+3rrfhOCxmEt3T2R6C82m2K/9OHr3Uy82SyWIkB w==; X-IronPort-AV: E=McAfee;i="6400,9594,10331"; a="329306353" X-IronPort-AV: E=Sophos;i="5.91,295,1647327600"; d="scan'208";a="329306353" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 10:27:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,295,1647327600"; d="scan'208";a="581497030" Received: from anguy11-desk2.jf.intel.com ([10.166.244.147]) by orsmga008.jf.intel.com with ESMTP; 28 Apr 2022 10:27:13 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com Cc: Wan Jiabing , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, Gurucharan Subject: [PATCH net-next 02/11] ice: use min_t() to make code cleaner in ice_gnss Date: Thu, 28 Apr 2022 10:24:21 -0700 Message-Id: <20220428172430.1004528-3-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220428172430.1004528-1-anthony.l.nguyen@intel.com> References: <20220428172430.1004528-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wan Jiabing Fix the following coccicheck warning: ./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min() Signed-off-by: Wan Jiabing Tested-by: Gurucharan (A Contingent worker at Intel) Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_gnss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_gnss.c b/drivers/net/ethernet/intel/ice/ice_gnss.c index 35579cf4283f..57586a2e6dec 100644 --- a/drivers/net/ethernet/intel/ice/ice_gnss.c +++ b/drivers/net/ethernet/intel/ice/ice_gnss.c @@ -76,8 +76,7 @@ static void ice_gnss_read(struct kthread_work *work) for (i = 0; i < data_len; i += bytes_read) { u16 bytes_left = data_len - i; - bytes_read = bytes_left < ICE_MAX_I2C_DATA_SIZE ? bytes_left : - ICE_MAX_I2C_DATA_SIZE; + bytes_read = min_t(typeof(bytes_left), bytes_left, ICE_MAX_I2C_DATA_SIZE); err = ice_aq_read_i2c(hw, link_topo, ICE_GNSS_UBX_I2C_BUS_ADDR, cpu_to_le16(ICE_GNSS_UBX_EMPTY_DATA), -- 2.31.1