From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1140AC4332F for ; Thu, 28 Apr 2022 21:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352253AbiD1V1L (ORCPT ); Thu, 28 Apr 2022 17:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352099AbiD1V1B (ORCPT ); Thu, 28 Apr 2022 17:27:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB8D6B9F23 for ; Thu, 28 Apr 2022 14:23:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5B302B8303F for ; Thu, 28 Apr 2022 21:23:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4E9CC385A9; Thu, 28 Apr 2022 21:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651181024; bh=ix1JmY3/nHR1YjFoqzZ7U4J02sb0Wc79WwQkZ+yRI6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QM8moCLUq/5eYAqwahubUhNyw0j9BZ2FUyxrccLz9oF/MteFwbmv6JgpID8h9Z7n9 xo37bPSS8CAvvJw4DMgAtMWovaV0cEoqxcFjDt5K4+7wmGJjecHV8KEHoMImcC+Bzt P2D/zSPHkOXDoO3wOcm++fdbdJBxgGhFTYBB3NudPeW9apcaosNexTSEOQ9kUWW+Z7 bx2Y0WwtjMWXuqtGiLjkDW7ILRayOF+K/WyzmdLA6u3hn0StoHUquWzoTsNX1FYIr+ sNRa1XcIdjbZut6JgVZqk+nrpyU5nHwQQRCM9zjvGrr9GhUTTbnfDChgChXaWBs+l/ xNqm3wLWBD04g== From: Jakub Kicinski To: davem@davemloft.net, pabeni@redhat.com Cc: edumazet@google.com, netdev@vger.kernel.org, Jakub Kicinski , claudiu.manoil@nxp.com Subject: [PATCH net-next v2 11/15] eth: gfar: remove a copy of the NAPI_POLL_WEIGHT define Date: Thu, 28 Apr 2022 14:23:19 -0700 Message-Id: <20220428212323.104417-12-kuba@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220428212323.104417-1-kuba@kernel.org> References: <20220428212323.104417-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Defining local versions of NAPI_POLL_WEIGHT with the same values in the drivers just makes refactoring harder. Signed-off-by: Jakub Kicinski --- CC: claudiu.manoil@nxp.com --- drivers/net/ethernet/freescale/gianfar.c | 2 +- drivers/net/ethernet/freescale/gianfar.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 206b7a35eaf5..f0b652a65043 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -3232,7 +3232,7 @@ static int gfar_probe(struct platform_device *ofdev) /* Register for napi ...We are registering NAPI for each grp */ for (i = 0; i < priv->num_grps; i++) { netif_napi_add(dev, &priv->gfargrp[i].napi_rx, - gfar_poll_rx_sq, GFAR_DEV_WEIGHT); + gfar_poll_rx_sq, NAPI_POLL_WEIGHT); netif_tx_napi_add(dev, &priv->gfargrp[i].napi_tx, gfar_poll_tx_sq, 2); } diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h index ca5e14f908fe..68b59d3202e3 100644 --- a/drivers/net/ethernet/freescale/gianfar.h +++ b/drivers/net/ethernet/freescale/gianfar.h @@ -52,9 +52,6 @@ struct ethtool_rx_list { unsigned int count; }; -/* The maximum number of packets to be handled in one call of gfar_poll */ -#define GFAR_DEV_WEIGHT 64 - /* Length for FCB */ #define GMAC_FCB_LEN 8 -- 2.34.1