From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A37C433EF for ; Thu, 28 Apr 2022 21:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352246AbiD1V1M (ORCPT ); Thu, 28 Apr 2022 17:27:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352171AbiD1V1B (ORCPT ); Thu, 28 Apr 2022 17:27:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73496BF531 for ; Thu, 28 Apr 2022 14:23:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0538C61F49 for ; Thu, 28 Apr 2022 21:23:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BEDBC385B3; Thu, 28 Apr 2022 21:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651181025; bh=VVgJTW5MgODJKkM2WWDvGTK+o+CHA/IvC3faoxsut+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JuBlf6BNhlTE5NKZzhqfeTaThK04H8jJbUaQtSQVgjrXoxXKbsnmP5UdPL74k4sif BSkDzccvsAsu5lKJ1SDzXIocVFgKm+wYCJUiKx7K5rYkZFk+NsXBYP+MA52Di58vUs Uh3+hEFPGzYA1h6cWIrBEkiX0JWvpBYgAQGf5WQbjyMXiDtZqjMJQpFpz9ZwKCC30E XtKcjvNTITg/qn0kmnnuJtI4JUbHoOLZWxzZHZHulDPBtoyYQBiiMoRNyBYoRHwdr5 9LNcP+ctACHJlcgDNZqLg9ocNzwyD3AfqgtKmk6kxivQnWXjQJdr2slQDwfPzpBJ62 pmPqSJr2XbpzQ== From: Jakub Kicinski To: davem@davemloft.net, pabeni@redhat.com Cc: edumazet@google.com, netdev@vger.kernel.org, Jakub Kicinski , romieu@fr.zoreil.com Subject: [PATCH net-next v2 14/15] eth: velocity: remove a copy of the NAPI_POLL_WEIGHT define Date: Thu, 28 Apr 2022 14:23:22 -0700 Message-Id: <20220428212323.104417-15-kuba@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220428212323.104417-1-kuba@kernel.org> References: <20220428212323.104417-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Defining local versions of NAPI_POLL_WEIGHT with the same values in the drivers just makes refactoring harder. Signed-off-by: Jakub Kicinski --- CC: romieu@fr.zoreil.com --- drivers/net/ethernet/via/via-velocity.c | 3 +-- drivers/net/ethernet/via/via-velocity.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c index be2b992f24d9..ff0c102cb578 100644 --- a/drivers/net/ethernet/via/via-velocity.c +++ b/drivers/net/ethernet/via/via-velocity.c @@ -2846,8 +2846,7 @@ static int velocity_probe(struct device *dev, int irq, netdev->netdev_ops = &velocity_netdev_ops; netdev->ethtool_ops = &velocity_ethtool_ops; - netif_napi_add(netdev, &vptr->napi, velocity_poll, - VELOCITY_NAPI_WEIGHT); + netif_napi_add(netdev, &vptr->napi, velocity_poll, NAPI_POLL_WEIGHT); netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_HW_VLAN_CTAG_TX; diff --git a/drivers/net/ethernet/via/via-velocity.h b/drivers/net/ethernet/via/via-velocity.h index d3f960cc7c6e..c02a9654dce6 100644 --- a/drivers/net/ethernet/via/via-velocity.h +++ b/drivers/net/ethernet/via/via-velocity.h @@ -23,7 +23,6 @@ #define VELOCITY_VERSION "1.15" #define VELOCITY_IO_SIZE 256 -#define VELOCITY_NAPI_WEIGHT 64 #define PKT_BUF_SZ 1540 -- 2.34.1